Skip to content
This repository has been archived by the owner on Jul 20, 2021. It is now read-only.

Commit

Permalink
(SIMP-1595) Provide complete dependency boundaries
Browse files Browse the repository at this point in the history
Before this patch, dependencies in `metadata.json` and
`build/rpm_metadata/requires` were missing upper boundaries and often
listed inaccurate lower boundaries.  This created an extremely fragile
5.2.X/4.3.X module ecosystem on the Forge, as a major release in any
dependency would be certain to break the module.

This commit resolves the issue by introducing upper and lower boundaries
for each dependency in `metadata.json` and propagates those dependencies
to the RPM dependencies listed in `build/rpm_metadata/requires`.

The minimum version boundaries were determined from the modules as they
were checked out in `simp-core` for the latest SIMP 5.2.X/4.3.X release
(with the addition recent z-version bumps from Forge-readiness patches).

SIMP-1595 #comment Fixed `pupmod-simp-ganglia`
SIMP-1655 #close

Change-Id: If01052b41ff4b2124f363c3fac88a82ff832d451
  • Loading branch information
op-ct committed Oct 10, 2016
1 parent 70323b9 commit 22e52d3
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 14 deletions.
13 changes: 10 additions & 3 deletions build/rpm_metadata/requires
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
Requires: pupmod-simp-apache >= 2.0.0-0
Requires: pupmod-simp-simpcat >= 2.1.0-1
Requires: pupmod-simp-iptables >= 2.0.0-0
Obsoletes: pupmod-ganglia-test
Requires: pupmod-puppetlabs-stdlib < 5.0.0-0
Requires: pupmod-puppetlabs-stdlib >= 4.9.0-0
Requires: pupmod-simp-apache < 5.0.0-0
Requires: pupmod-simp-apache >= 4.1.6-0
Requires: pupmod-simp-iptables < 5.0.0-0
Requires: pupmod-simp-iptables >= 4.1.4-0
Requires: pupmod-simp-simpcat < 6.0.0-0
Requires: pupmod-simp-simpcat >= 5.0.1-0
Requires: pupmod-simp-simplib < 2.0.0-0
Requires: pupmod-simp-simplib >= 1.3.1-0
26 changes: 15 additions & 11 deletions metadata.json
Original file line number Diff line number Diff line change
@@ -1,33 +1,37 @@
{
"name": "simp-ganglia",
"version": "5.0.0",
"author": "simp",
"name": "simp-ganglia",
"version": "5.0.1",
"author": "simp",
"summary": "default profiles for core SIMP installations",
"license": "Apache-2.0",
"source": "https://github.com/simp/pupmod-simp-ganglia",
"source": "https://github.com/simp/pupmod-simp-ganglia",
"project_page": "https://github.com/simp/pupmod-simp-ganglia",
"issues_url": "https://simp/project.atlassian.net",
"tags": [ "simp", "profiles"],
"issues_url": "https://simp-project.atlassian.net",
"tags": [
"simp",
"ganglia",
"monitoring"
],
"dependencies": [
{
"name": "simp/apache",
"version_requirement": ">= 2.0.0"
"version_requirement": ">= 4.1.6 < 5.0.0"
},
{
"name": "simp/iptables",
"version_requirement": ">= 2.0.0"
"version_requirement": ">= 4.1.4 < 5.0.0"
},
{
"name": "simp/simpcat",
"version_requirement": ">= 2.1.0"
"version_requirement": ">= 5.0.1 < 6.0.0"
},
{
"name": "simp/simplib",
"version_requirement": ">= 4.2.0"
"version_requirement": ">= 1.3.1 < 2.0.0"
},
{
"name": "puppetlabs/stdlib",
"version_requirement": ">= 4.1.0"
"version_requirement": ">= 4.9.0 < 5.0.0"
}
],
"operatingsystem_support": [
Expand Down

0 comments on commit 22e52d3

Please sign in to comment.