Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unmask_rpc-gssd.service exec resource #110

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

silug
Copy link
Contributor

@silug silug commented Aug 21, 2024

Fixes #109

@ianc769
Copy link

ianc769 commented Aug 21, 2024

@silug

Quick tests in my local dev:

nfs::client_enabled: true
nfs::nfs_v4_client: true
nfs::secure_nfs: true

Using Puppetfile:

mod 'simp-nfs',
    :git => 'git@github.com:silug/pupmod-simp-nfs.git',
    :branch => 'issue_109',
    :default_branch => 'main'

First Run, Expecting the change:

root@server01:[~]: prun enable-secure-nfs
running: puppet agent --test --environment enable_secure_nfs
Info: Refreshing CA certificate
Info: CA certificate is unmodified, using existing CA certificate
Info: Refreshing CRL
Info: CRL is unmodified, using existing CRL
Info: Using environment 'enable_secure_nfs'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Notice: Requesting catalog from puppet:8140 (X.X.X.X)
Notice: Catalog compiled by pmaster-1.local
Info: Caching catalog for server01.local
Info: Applying configuration version 'pmaster-1-enable_secure_nfs-ed1fd319135'
Notice: /Stage[main]/Nfs::Base::Service/Exec[unmask_rpc-gssd.service]/returns: executed successfully (corrective)
Info: /Stage[main]/Nfs::Base::Service/Exec[unmask_rpc-gssd.service]: Scheduling refresh of Service[rpc-gssd.service]
Notice: /Stage[main]/Nfs::Base::Service/Service[rpc-gssd.service]: Triggered 'refresh' from 1 event
Info: Class[Nfs::Base::Service]: Scheduling refresh of Class[Nfs::Client::Service]
Info: Class[Nfs::Client::Service]: Scheduling refresh of Service[nfs-client.target]
Notice: /Stage[main]/Nfs::Client::Service/Service[nfs-client.target]: Triggered 'refresh' from 1 event
Notice: Applied catalog in 16.71 seconds

Second Run Exepecting no change:

root@server01:[~]: prun enable-secure-nfs
running: puppet agent --test --environment enable_secure_nfs
Info: Refreshing CA certificate
Info: CA certificate is unmodified, using existing CA certificate
Info: Refreshing CRL
Info: CRL is unmodified, using existing CRL
Info: Using environment 'enable_secure_nfs'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Notice: Requesting catalog from puppet:8140 (X.X.X.X)
Notice: Catalog compiled by pmaster-1.local
Info: Caching catalog for server01.local
Info: Applying configuration version 'pmaster-1-enable_secure_nfs-ed1fd319135'
Notice: Applied catalog in 16.23 seconds

root@server01:[~]: /usr/bin/systemctl status rpc-gssd.service | grep Loaded
   Loaded: loaded (/usr/lib/systemd/system/rpc-gssd.service; static; vendor preset: disabled)

Seems good! 👍

@silug silug merged commit 11f90bf into simp:master Aug 22, 2024
9 checks passed
@silug silug deleted the issue_109 branch August 22, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: Base Service unmask exec is incorrect.
3 participants