(SIMP-6238) Update to puppet-gitlab v3.0.2 #28
Conversation
- Switched from vshn/gitlab 1.13.3 to its replacement puppet/gitlab 3.0.2 and reworked the manifests, as appropriate, to work with the newer module. - Added manage_package and package_ensure parameters to simp_gitlab SIMP-6284 #close SIMP-6285 #close SIMP-6238 #close
|
|
||
| context 'simp_gitlab class without any parameters' do | ||
| let(:params) {{ }} | ||
| it_behaves_like 'a structured module' | ||
|
|
There was a problem hiding this comment.
Was there a reason to expand the it_behaves_like 'a structured module' into each individual line?
There was a problem hiding this comment.
It was only used in one place. So I thought the test was more clear with the example group expanded.
| # installed and that an initial reconfigure with the GITLAB_ROOT_PASSWORD | ||
| # environment variable set is executed. | ||
| # | ||
| # The reason the gitlab.rb/RPM ordering is important is as follows: |
There was a problem hiding this comment.
The details in this explanation would help a lot at voxpupuli/puppet-gitlab#301
Co-Authored-By: lnemsick-simp <lnemsick-simp@users.noreply.github.com>
| use of the component module [`vshn/gitlab`][vshn_gitlab]. It is important to | ||
| note that `vshn-gitlab` configures the GitLab Omnibus's `/etc/gitlab/gitlab.rb` | ||
| use of the component module [`puppet/gitlab`][puppet_gitlab]. It is important to | ||
| note that `puppet-gitlab` configures the GitLab Omnibus's `/etc/gitlab/gitlab.rb` | ||
| and runs `gitlab-ctl reconfigure`. |
There was a problem hiding this comment.
puppet-gitlab no longer executes gitlab-ctl reconfigure explicitly unless you configure it to do so. Your package manager will do this whenever you install or upgrade the omnibus-gitlab package, as that's part of the omnibus's post-install script.
This same script in the omnibus also starts the gitlab supervisors for the relevant roles defined in the nodes gitlab.rb, and as such the puppet_gitlab module no longer manages the service explicitly by default.
I left some links to relevant info in the issue you opened in our repo. Let me know if you need any other information.
|
This might be some interesting reading for you as well: voxpupuli/puppet-gitlab#240 |
3.0.2 and reworked the manifests, as appropriate, to work with the
newer module.
SIMP-6284 #close
SIMP-6285 #close
SIMP-6238 #close