Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in travis early exits #100

Closed
lheagy opened this issue Jul 20, 2018 · 0 comments
Closed

Bug in travis early exits #100

lheagy opened this issue Jul 20, 2018 · 0 comments
Labels

Comments

@lheagy
Copy link
Member

lheagy commented Jul 20, 2018

The latest pypi release deployed earlier than anticipated (thanks @jcapriot for catching this). It wasn't a problem as the deployed version was what we intended to deploy - however, it should have been deployed only upon the merge to master or the tagged release...

after_success:

  - bash <(curl -s https://codecov.io/bash)

  # early exit if not on a deplotment branch
  - if ! [ "$TRAVIS_BRANCH" = "$MASTER_BRANCH" -o "$TRAVIS_TAG" = "true" ]; then
      echo "Not deploying (because this is not a deployment branch)" ;
      exit 0 ;
    fi
  - if [ "$TRAVIS_PULL_REQUEST" = "true" ]; then
      echo "Not deploying (because this is a pull request)" ;
      exit 0 ;
    fi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant