Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tree.pxd in source distribution #102

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Include tree.pxd in source distribution #102

merged 2 commits into from
Jul 25, 2018

Conversation

cgohlke
Copy link
Contributor

@cgohlke cgohlke commented Jul 24, 2018

No description provided.

@jcapriot
Copy link
Member

Never even thought to think of what was and wasn’t included in sdist. Definitely should be pulled in.

@lheagy
Copy link
Member

lheagy commented Jul 24, 2018

Excellent, thanks @cgohlke! I will wait until the travis test goes through and then pull this in

@jcapriot
Copy link
Member

I think the current fail has to deal with the current non-early exit bug in the Travis script

@lheagy
Copy link
Member

lheagy commented Jul 24, 2018

yeah, it seems to be related to #100

@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   76.29%   76.29%           
=======================================
  Files          17       17           
  Lines        4151     4151           
=======================================
  Hits         3167     3167           
  Misses        984      984

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5681bd2...e226c1c. Read the comment docs.

@lheagy lheagy merged commit 2c4ca6d into simpeg:master Jul 25, 2018
@lheagy
Copy link
Member

lheagy commented Jul 25, 2018

Thanks @cgohlke! This has been included in discretize 0.3.2 which is now available on pypi: https://pypi.org/project/discretize/ (windows wheels to follow shorty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants