-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/tree functions #177
Feat/tree functions #177
Conversation
…(i.e. parent cells)
… of TreeCell Also had the wrong indentation level on the interpolation matrix function
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
- Coverage 81.02% 80.36% -0.66%
==========================================
Files 23 23
Lines 4848 5328 +480
==========================================
+ Hits 3928 4282 +354
- Misses 920 1046 +126
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
- Coverage 83.1% 81.94% -1.16%
==========================================
Files 23 23
Lines 4894 4974 +80
==========================================
+ Hits 4067 4076 +9
- Misses 827 898 +71
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for all of the docstrings! This is looking good. I have just merged the latest master and will see what happens with the testing. It looks like the previous fail was due to python 2.7. If it is still the case, I am totally fine dropping the python 2.7 testing and noting that we no longer explicitly support 2.7 rather than going hunting for the issue.
@jcapriot, @micmitch were there any other updates you wanted to make before we merge this in?
@property | ||
def permuteCC(self): | ||
"""Permutation matrix re-ordering of cells sorted by x, then y, then z""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the doc-strings :)
I don't have any more local things left on this so I'm good to pull this in |
It seems that only python 2.7 is giving issues here. I am inclined to just remove testing and indicate that we no longer explicitly support python 2.7. Are there any concerns with this? |
The addition of several functions from @jcapriot to make it easier to work with octree meshes. Several of the functions are used to integrate line source terms for FDEM. Other improvements include updating documentation and improving plotGrid to visualize octree meshes and models.