Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change name and description of average edge to face #314

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

jcapriot
Copy link
Member

Fixes the averaging operator to actually do something that it describes. Before it was doing an odd operation that was only relevant to the boundary integrals, and even then only to coordinate aligned axes. Now it switches it to actually average things, and then changes it to the needed part for the boundary integral

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #314 (838a15f) into main (bffe98a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #314   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files          38       38           
  Lines       11301    11303    +2     
=======================================
+ Hits         9632     9634    +2     
  Misses       1669     1669           
Impacted Files Coverage Δ
discretize/_extensions/tree_ext.pyx 84.44% <100.00%> (ø)
discretize/base/base_mesh.py 93.01% <100.00%> (ø)
discretize/operators/differential_operators.py 81.00% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jcapriot jcapriot merged commit 61e0b64 into simpeg:main Apr 25, 2023
@jcapriot jcapriot deleted the average_edge_to_face branch April 25, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant