Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching of internal projection matrices #375

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

jcapriot
Copy link
Member

@jcapriot jcapriot commented Sep 25, 2024

Change projection caching to depend on both the projection type and the with_volume kwarg.

(And update broken links in the docs. The python-for-scientists site was moved to pyzo.)

change projection caching to depend on both the projection type and the with_volume kwarg
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.29%. Comparing base (0926391) to head (730287c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   86.28%   86.29%           
=======================================
  Files          89       89           
  Lines       18716    18726   +10     
  Branches     2961     2961           
=======================================
+ Hits        16149    16159   +10     
  Misses       1881     1881           
  Partials      686      686           
Flag Coverage Δ
86.29% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapriot jcapriot merged commit b8bdafb into simpeg:main Oct 3, 2024
25 checks passed
@jcapriot jcapriot deleted the bug/simplex_caching branch October 3, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant