Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci mainenance #74

Merged
merged 12 commits into from
Oct 13, 2024
Merged

Ci mainenance #74

merged 12 commits into from
Oct 13, 2024

Conversation

jcapriot
Copy link
Member

Updates for numpy 2.0 and general CI maintenance.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (e8dc9eb) to head (57b76be).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #74       +/-   ##
==========================================
- Coverage   87.45%   0.00%   -87.46%     
==========================================
  Files          30      30               
  Lines        3078    3079        +1     
==========================================
- Hits         2692       0     -2692     
- Misses        386    3079     +2693     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapriot
Copy link
Member Author

Coverage is at 0% due to having to actually install it using pip in a non-editable mode.

This is because no release of discretize is currently built against numpy 2.0 on conda-forge (which this now requires). Looking at how discretize is used here, it should be simple enough to remove it from most testing requirements, and make it optional for those others.

@jcapriot jcapriot merged commit 1c5eb5a into main Oct 13, 2024
7 of 8 checks passed
@jcapriot jcapriot deleted the ci_mainenance branch October 13, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant