Skip to content

Commit

Permalink
Sonobi - suppress user sync error (prebid#2686)
Browse files Browse the repository at this point in the history
* added vp param to trinity request

* added lib_name and lib_v to trinity

* return null from buildRequests if there is no keymakers

* added test case for empty keymaker

* only importing functions we need from utils

* changed window.pbjs.version to use the gulp repalced macro .version$

* fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port

* fixed lint issue

* fixed issue where sonobi getUserSync was throwing an error on timeout

* sonobi support referrer param

* fixed unit test for testing the ref param on bid request

* return null from buildRequests if there is no keymakers

* fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port

* Add gdpr support

* no longer logging error when getUserSync fails to parse a serverResponse
  • Loading branch information
JonGoSonobi authored and AlessandroDG committed Sep 13, 2018
1 parent 065fed9 commit b47c363
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 1 addition & 3 deletions modules/sonobiBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,7 @@ export const spec = {
});
});
}
} catch (e) {
logError(e)
}
} catch (e) {}
return syncs;
}
};
Expand Down
3 changes: 2 additions & 1 deletion test/spec/modules/sonobiBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,8 @@ describe('SonobiBidAdapter', () => {

it('should return an empty array', () => {
expect(spec.getUserSyncs({ pixelEnabled: false }, bidResponse)).to.have.length(0);
})
expect(spec.getUserSyncs({ pixelEnabled: true }, [])).to.have.length(0);
});
})
describe('_getPlatform', () => {
it('should return mobile', () => {
Expand Down

0 comments on commit b47c363

Please sign in to comment.