Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump semantic-release from 17.1.1 to 17.2.3 #19

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 18, 2020

Bumps semantic-release from 17.1.1 to 17.2.3.

Release notes

Sourced from semantic-release's releases.

v17.2.3

17.2.3 (2020-11-16)

Bug Fixes

  • mask secrets when characters get uri encoded (ca90b34)

v17.2.2

17.2.2 (2020-10-29)

Bug Fixes

  • don't parse port as part of the path in repository URLs (#1671) (77a75f0)
  • use valid git credentials when multiple are provided (#1669) (2bf3771)

v17.2.1

17.2.1 (2020-10-12)

Reverts

  • Revert "feat: throw an Error if package.json has duplicate "repository" key (#1656)" (3abcbaf), closes #1656 #1657

v17.2.0

17.2.0 (2020-10-11)

Features

  • throw an Error if package.json has duplicate "repository" key (#1656) (b8fb35c)

v17.1.2

17.1.2 (2020-09-17)

Bug Fixes

  • add logging for when ssh falls back to http (#1639) (b4c5d0a)
Commits
  • c8d38b6 style: removed line breaks to align with xo rule (#1689)
  • ca90b34 fix: mask secrets when characters get uri encoded
  • 63fa143 docs(plugins): add listing for new plugin (#1686)
  • 2bf3771 fix: use valid git credentials when multiple are provided (#1669)
  • 77a75f0 fix: don't parse port as part of the path in repository URLs (#1671)
  • d74ffef docs: add npm-deprecate-old-versions in plugins list (#1667)
  • 3abcbaf Revert "feat: throw an Error if package.json has duplicate "repository" key (...
  • b8fb35c feat: throw an Error if package.json has duplicate "repository" key (#1656)
  • 18e35b2 docs: reorder default plugins list (#1650)
  • e35e5bb docs(contributing): fix commit message examples (#1648)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 18, 2020
@ericcornelissen
Copy link
Contributor

Merging this should be completely fine as the changes are pretty trivial.

On slightly different note, it seems this project doesn't need semantic release as an explicit devDependency. The only place semantic-release seems to be used is in the release.yml workflow. Either

  1. semantic-release can be release and this (and related) Pull Request can be closed, or
  2. The npm installed version of semantic-release is used in the release workflow.

The former is easier, the latter has some advantages from a security perspective as it would (somewhat) pin the semantic-release version avoid problems if a malicious version is released.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/semantic-release-17.2.3 branch from 74b87bd to 85ccc72 Compare June 12, 2021 19:03
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/semantic-release-17.2.3 branch from 85ccc72 to 964b1f8 Compare June 12, 2021 19:05
@birjj birjj merged commit 1691711 into master Jun 12, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/semantic-release-17.2.3 branch June 12, 2021 19:07
@birjj
Copy link
Contributor

birjj commented Jun 12, 2021

Good spot @ericcornelissen. Could I get you to handle removing the dep from the repo before next release?

@github-actions
Copy link

🎉 This PR is included in version 1.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants