Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add atomic values in API messages #92

Merged
merged 4 commits into from
Oct 31, 2023
Merged

feat: Add atomic values in API messages #92

merged 4 commits into from
Oct 31, 2023

Conversation

regseb
Copy link
Contributor

@regseb regseb commented Oct 27, 2023

Fix #91

ericcornelissen
ericcornelissen reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me. Any chance there's a test that can be updated (or added) to verify the changes? Else, could you provide me with some steps to verify the changes manually?

@regseb
Copy link
Contributor Author

regseb commented Oct 28, 2023

I've added tests for the Reporter class. I've also updated the expect dependency to have .toMatchObject(object) method.

ericcornelissen
ericcornelissen reviewed Oct 29, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@ericcornelissen ericcornelissen merged commit 718e622 into simple-icons:master Oct 31, 2023
14 checks passed
@ericcornelissen
Copy link
Contributor

Thank you very much for your contribution @regseb!

@github-actions
Copy link

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@regseb regseb deleted the atomic branch October 31, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcornelissen ericcornelissen ericcornelissen left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add atomic values in API messages
2 participants
@regseb @ericcornelissen