Skip to content

Commit

Permalink
Remove automagic rake simplecov integration
Browse files Browse the repository at this point in the history
Was causing issues, was undocumented either way and too many
headaches to make it work fully with all integrations
#689 (comment)

Fixes #689
  • Loading branch information
PragTob committed Dec 15, 2019
1 parent 9bd26c0 commit 5f84423
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 25 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Unrealeased

## Breaking
* Dropped official support for all EOL'ed rubies meaning we only officially support 2.4+ - older rubies might still work but are not guaranteed to do so. Older release should still work. (thanks [@deivid-rodriguez](https://github.com/deivid-rodriguez))
* Dropped the `rake simplecov` task that "magically" integreated with rails. It was always undocumented, caused some issues and [had some issues](https://github.com/colszowka/simplecov/issues/689#issuecomment-561572327). Use the integration as described in the README please :)

## Enhancements

Expand Down
3 changes: 0 additions & 3 deletions lib/simplecov.rb
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,3 @@ def result_with_not_loaded_files

# Load default config
require "simplecov/defaults" unless ENV["SIMPLECOV_NO_DEFAULTS"]

# Load Rails integration
require "simplecov/railtie" if defined? Rails::Railtie
9 changes: 0 additions & 9 deletions lib/simplecov/railtie.rb

This file was deleted.

13 changes: 0 additions & 13 deletions lib/simplecov/railties/tasks.rake

This file was deleted.

0 comments on commit 5f84423

Please sign in to comment.