-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional exit code > 0 when coverage percentage goes down #11
Comments
This will be awesome. Thank you. Do you feel it is hard or relatively easy? I would love to help if I may. |
Not sure how this would work when bounding between filtered and unfiltered specs as the coverage amount would change between test runs. However, you may want to checkout cane from Square. It is a code quality tool that specifically allows for build failures when code coverage drops below a certain amount. |
This will be very easy to add now that #90 is part of master, basically I'd just add a |
Make this package to Ruby 1.9.3 only. v0.7.1, 2012-10-12 ([changes](simplecov-ruby/simplecov@v0.7.0...v0.7.1)) ------------------- * [BUGFIX] The gem packages of 0.7.0 (both simplecov and simplecov-html) pushed to Rubygems had some file permission issues, leading to problems when installing SimpleCov in a root/system Rubygems install and then trying to use it as a normal user (see simplecov-ruby/simplecov#171, thanks @envygeeks for bringing it up). The gem build process has been changed to always enforce proper permissions before packaging to avoid this issue in the future. v0.7.0, 2012-10-10 ([changes](simplecov-ruby/simplecov@v0.6.4...v0.7.0)) ------------------- * [FEATURE] The new `maximum_coverage_drop` and `minimum_coverage` now allow you to fail your build when the coverage dropped by more than what you allowed or is below a minimum value required. Also, `refuse_coverage_drop` disallows any coverage drops between test runs. See simplecov-ruby/simplecov#151, simplecov-ruby/simplecov#11, simplecov-ruby/simplecov#90, and simplecov-ruby/simplecov#96 (thanks to @infertux) * [FEATURE] SimpleCov now ships with a built-in MultiFormatter which allows the easy usage of multiple result formatters at the same time without the need to write custom wrapper code. See simplecov-ruby/simplecov#158 (thanks to @nikitug) * [BUGFIX] The usage of digits, hyphens and underscores in group names could lead to broken tab navigation in the default simplecov-html reports. See simplecov-ruby/simplecov-html#14 (thanks to @ebelgarts) * [REFACTORING] A few more ruby warnings removed. See simplecov-ruby/simplecov#106 and simplecov-ruby/simplecov#139. (thanks to @lukejahnke) * A [Pledgie button](simplecov-ruby/simplecov@63cfa99) for those that feel generous :) * The usual bunch of README fixes and documentation tweaks. Thanks to everyone who contributed those!
Make this package to Ruby 1.9.3 only. v0.7.1, 2012-10-12 ([changes](simplecov-ruby/simplecov@v0.7.0...v0.7.1)) ------------------- * [BUGFIX] The gem packages of 0.7.0 (both simplecov and simplecov-html) pushed to Rubygems had some file permission issues, leading to problems when installing SimpleCov in a root/system Rubygems install and then trying to use it as a normal user (see simplecov-ruby/simplecov#171, thanks @envygeeks for bringing it up). The gem build process has been changed to always enforce proper permissions before packaging to avoid this issue in the future. v0.7.0, 2012-10-10 ([changes](simplecov-ruby/simplecov@v0.6.4...v0.7.0)) ------------------- * [FEATURE] The new `maximum_coverage_drop` and `minimum_coverage` now allow you to fail your build when the coverage dropped by more than what you allowed or is below a minimum value required. Also, `refuse_coverage_drop` disallows any coverage drops between test runs. See simplecov-ruby/simplecov#151, simplecov-ruby/simplecov#11, simplecov-ruby/simplecov#90, and simplecov-ruby/simplecov#96 (thanks to @infertux) * [FEATURE] SimpleCov now ships with a built-in MultiFormatter which allows the easy usage of multiple result formatters at the same time without the need to write custom wrapper code. See simplecov-ruby/simplecov#158 (thanks to @nikitug) * [BUGFIX] The usage of digits, hyphens and underscores in group names could lead to broken tab navigation in the default simplecov-html reports. See simplecov-ruby/simplecov-html#14 (thanks to @ebelgarts) * [REFACTORING] A few more ruby warnings removed. See simplecov-ruby/simplecov#106 and simplecov-ruby/simplecov#139. (thanks to @lukejahnke) * A [Pledgie button](simplecov-ruby/simplecov@63cfa99) for those that feel generous :) * The usual bunch of README fixes and documentation tweaks. Thanks to everyone who contributed those!
Make this package to Ruby 1.9.3 only. v0.7.1, 2012-10-12 ([changes](simplecov-ruby/simplecov@v0.7.0...v0.7.1)) ------------------- * [BUGFIX] The gem packages of 0.7.0 (both simplecov and simplecov-html) pushed to Rubygems had some file permission issues, leading to problems when installing SimpleCov in a root/system Rubygems install and then trying to use it as a normal user (see simplecov-ruby/simplecov#171, thanks @envygeeks for bringing it up). The gem build process has been changed to always enforce proper permissions before packaging to avoid this issue in the future. v0.7.0, 2012-10-10 ([changes](simplecov-ruby/simplecov@v0.6.4...v0.7.0)) ------------------- * [FEATURE] The new `maximum_coverage_drop` and `minimum_coverage` now allow you to fail your build when the coverage dropped by more than what you allowed or is below a minimum value required. Also, `refuse_coverage_drop` disallows any coverage drops between test runs. See simplecov-ruby/simplecov#151, simplecov-ruby/simplecov#11, simplecov-ruby/simplecov#90, and simplecov-ruby/simplecov#96 (thanks to @infertux) * [FEATURE] SimpleCov now ships with a built-in MultiFormatter which allows the easy usage of multiple result formatters at the same time without the need to write custom wrapper code. See simplecov-ruby/simplecov#158 (thanks to @nikitug) * [BUGFIX] The usage of digits, hyphens and underscores in group names could lead to broken tab navigation in the default simplecov-html reports. See simplecov-ruby/simplecov-html#14 (thanks to @ebelgarts) * [REFACTORING] A few more ruby warnings removed. See simplecov-ruby/simplecov#106 and simplecov-ruby/simplecov#139. (thanks to @lukejahnke) * A [Pledgie button](simplecov-ruby/simplecov@63cfa99) for those that feel generous :) * The usual bunch of README fixes and documentation tweaks. Thanks to everyone who contributed those!
See http://twitter.com/#!/hayafirst/status/28368786944
And my responses:
Check out custom exit behaviour: http://bit.ly/953iOR - could raise an exception after result change. See http://bit.ly/9PSaOt
Basically, cache the result.covered_percent somewhere, then later compare it with previous and cause an exit with status > 0
This could be an (optional) built-in functionality.
The SimpleCov.result.covered_percent should be stored in coverage_path/last_coverage_percent, then compared with the current run.
Configure with:
The text was updated successfully, but these errors were encountered: