Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Back button does not work in coverage reports #263

Closed
DavidEGrayson opened this issue Nov 24, 2013 · 5 comments · Fixed by simplecov-ruby/simplecov-html#36
Closed
Labels

Comments

@DavidEGrayson
Copy link

The steps to reproduce this bug are:

  1. Generate a coverage report with SimpleCov.
  2. Open it in Google Chrome.
  3. Click on one of the filenames in the report.
  4. Click the back button.

At this point, I would expect the browser to go back to the previous screen I was on with the list of all the Ruby files. Instead, what actually happens is that I remain on the same screen I was already one. The URL seems to change back, but now the contents of the page.

I expect this to be easy to reproduce, but if it is not then my setup is:

jruby 1.7.4 (1.9.3p392) 2013-05-16 2390d3b on Java HotSpot(TM) 64-Bit Server VM 1.7.0_17-b02 [Windows 8-amd64]
simplecov gem 0.8.2
simplecov-html gem 0.8.0
Browsers tested:
Google Chrome 33.0.1712.4 dev-m
Internet Explorer 10.0.9200.16736

@xaviershay
Copy link
Collaborator

I was able to replicate this on latest master.

@asanghi
Copy link

asanghi commented Sep 29, 2014

This is still a problem.

@bf4
Copy link
Collaborator

bf4 commented Oct 26, 2014

@asanghi Would you be up to submit a PR?

@sunnyrjuneja
Copy link

@bf4 hey, there are two open PRs on this. any chance you could take a look?

@colszowka
Copy link
Collaborator

simplecov-html 0.9.0 is released that includes the fixes. To use it, you will need to bump simplecov to 0.9.2, which will ship in the next minutes once I got the changelog ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants