Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"track_files nil" not respected in latest release #462

Closed
kmewhort opened this issue Feb 10, 2016 · 3 comments
Closed

"track_files nil" not respected in latest release #462

kmewhort opened this issue Feb 10, 2016 · 3 comments

Comments

@kmewhort
Copy link

I believe this is due to a bug introduced in #447, per my comments here: https://github.com/colszowka/simplecov/pull/447/files
@kmewhort
Copy link
Author

Actually, on second look, those comments weren't accurate. The issue seems to remain though that the config setting isn't respected anymore.

@craiglittle
Copy link
Contributor

Could you expand on what you mean by "the config setting isn't respected anymore"? Is that true no matter what is passed to track_files or only with nil?

@kmewhort
Copy link
Author

@craiglittle, we just did some more investigation and it indeed seems like the issue is that track_files nil no longer has any effect. track_files false works though.

Is this change intentional? If so, maybe the solution is to simply add a note to the changelog.

craiglittle added a commit to craiglittle/simplecov that referenced this issue Feb 13, 2016
@craiglittle
Make track_files work when configured with nil
4058c2b 
Fixes simplecov-ruby#462.

The implementation of `track_files` was refactored recently to suppress
a warning in the underlying instance variable had not been initialized.
This had the effect of changing the behavior when trying to nullify the
default configuration of tracked files in some cases through the use of
nil.

With this change, a declaration of `track_files nil` will once again
clear out any previous configuration and essentially disable the
feature.

Reference:
  * simplecov-ruby#447
  * simplecov-ruby#462
craiglittle added a commit to craiglittle/simplecov that referenced this issue Feb 13, 2016
@craiglittle
Make track_files work when configured with nil
03f6470 
Fixes simplecov-ruby#462.

The implementation of `track_files` was refactored recently to suppress
a warning in the underlying instance variable had not been initialized.
This had the effect of changing the behavior when trying to nullify the
default configuration of tracked files in some cases through the use of
nil.

With this change, a declaration of `track_files nil` will once again
clear out any previous configuration and essentially disable the
feature.

Reference:
  * simplecov-ruby#447
  * simplecov-ruby#462
@craiglittle craiglittle mentioned this issue Feb 13, 2016
Closed
craiglittle added a commit to craiglittle/simplecov that referenced this issue Feb 13, 2016
@craiglittle
Make track_files work when configured with nil
53e8150 
Fixes simplecov-ruby#462.

The implementation of `track_files` was refactored recently to suppress
a warning in the underlying instance variable had not been initialized.
This had the effect of changing the behavior when trying to nullify the
default configuration of tracked files in some cases through the use of
nil.

With this change, a declaration of `track_files nil` will once again
clear out any previous configuration and essentially disable the
feature.

Reference:
  * simplecov-ruby#447
  * simplecov-ruby#462
craiglittle added a commit to craiglittle/simplecov that referenced this issue Feb 13, 2016
@craiglittle
Make track_files work when configured with nil
67a26d4 
Fixes simplecov-ruby#462.

The implementation of `track_files` was refactored recently to suppress
a warning in the underlying instance variable had not been initialized.
This had the effect of changing the behavior when trying to nullify the
default configuration of tracked files in some cases through the use of
nil.

With this change, a declaration of `track_files nil` will once again
clear out any previous configuration and essentially disable the
feature.

Reference:
  * simplecov-ruby#447
  * simplecov-ruby#462
@PragTob PragTob closed this as completed in 0be1563 Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmewhort @craiglittle