Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplecov fails to exit on rspec suite completion in Ruby 2.6.3 #740

Closed
doublephi opened this issue Aug 6, 2019 · 8 comments
Closed

Simplecov fails to exit on rspec suite completion in Ruby 2.6.3 #740

doublephi opened this issue Aug 6, 2019 · 8 comments

Comments

@doublephi
Copy link

doublephi commented Aug 6, 2019

So after upgrading the Ruby version used with my app from 2.5.5 to 2.6.3, simplecov 0.17.0 now hangs silently and permanently at the end of my test suite.

I'm running Ruby 2.6.3 and Rails 5.2.3.

As for what else may be relevant, I have capybara 3.26.0 running and I'm using RSpec.

Here's an example of the output I get:

138 examples, 0 failures, 1 pending

Randomized with seed 29475

Then that's where it hangs. One think I tried is adding "use_merging false" to my SimpleCov.start block, as I saw that suggested out and about. No luck for me.

Any help is greatly appreciated!

@trafium
Copy link

trafium commented Sep 4, 2019

Faced same issue, only thing that helped is rolling back to simplecov 0.16.1

schleuderrr pushed a commit to schleuder/schleuder that referenced this issue Sep 6, 2019
schleuderrr pushed a commit to schleuder/schleuder that referenced this issue Sep 6, 2019
schleuderrr pushed a commit to schleuder/schleuder that referenced this issue Sep 6, 2019
schleuderrr pushed a commit to schleuder/schleuder that referenced this issue Sep 6, 2019
schleuderrr pushed a commit to schleuder/schleuder that referenced this issue Sep 6, 2019
schleuderrr pushed a commit to schleuder/schleuder that referenced this issue Sep 6, 2019
schleuderrr pushed a commit to schleuder/schleuder that referenced this issue Sep 6, 2019
@PragTob
Copy link
Collaborator

PragTob commented Sep 16, 2019

Hi there,

thanks for the report 💚

Sorry I didn't have much time for OSS the last couple of months/weeks so I missed this 😞

It got fixed in the mean time in #746 and I released 0.17.1 to match. Please upgrade and let me know if it's really fixed.

@PragTob PragTob closed this as completed Sep 16, 2019
@constantine-nikolaou
Copy link

Hey @PragTob, thanks for the fix but it fails still with Ruby 2.6.5.

I had to revert back to version 0.16.1 as mentioned by @trafium above.

@PragTob PragTob reopened this Dec 26, 2019
@PragTob
Copy link
Collaborator

PragTob commented Dec 26, 2019

@cnicolaou that is really discomforting - would you happen to have an example repo you could share or something? Are you using parallel tests? For most other people 0.17.1 seems to work so this is kinda scary for me :)

@constantine-nikolaou
Copy link

@PragTob I take back what I have shared previously.

The error that happened was because i had duplicate configurations for SimpleCov, .simplecov and inside rails_helper.

PS: I am still using 0.16.1 though

I apologise for this inaccurate bug reporting, please feel free to close the ticket again.

@PragTob
Copy link
Collaborator

PragTob commented Dec 31, 2019

@cnicolaou no worries and thank you :)

@PragTob PragTob closed this as completed Dec 31, 2019
@tieeeeen1994
Copy link

tieeeeen1994 commented Jul 5, 2024

I am also having this issue. However, we are using Ruby 3.3.0. SimpleCov version is at 0.22.0.

I am not sure what's causing this. Any ideas what is causing this?

I should add that SimpleCov properly generates coverage reports when specifying files or folders. but running bundle exec rspec will cause this issue.

@tieeeeen1994
Copy link

An update; it seems that SimpleCov hangs when there's a lot of tests included in one command. I tried adding folders one by one, then when I added spec/folderA, it started hanging. However, upon running rspec on spec/folderA, all tests pass and SimpleCov was able to generate the report.

I'm not really sure what to do here anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants