-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when parsing previous version resultset.json #820
Labels
Milestone
Comments
Merged
Right now it's incomplete because of: if use_merging
wait_for_other_processes
SimpleCov::ResultMerger.store_result(@result) if result?
@result = SimpleCov::ResultMerger.merged_result
end If |
WIP fix/reproduction is up at #824 |
PragTob
added a commit
that referenced
this issue
Jan 16, 2020
Ensure a different name so merging doesn't just throw it out ResultMerger#store_result: clear_resultset new_set = resultset command_name, data = result.to_hash.first it might throw out the result, it might not 😱
PragTob
added a commit
that referenced
this issue
Jan 17, 2020
Ensure a different name so merging doesn't just throw it out ResultMerger#store_result: clear_resultset new_set = resultset command_name, data = result.to_hash.first it might throw out the result, it might not 😱
PragTob
added a commit
that referenced
this issue
Jan 18, 2020
Ensure a different name so merging doesn't just throw it out ResultMerger#store_result: clear_resultset new_set = resultset command_name, data = result.to_hash.first it might throw out the result, it might not 😱
Fixed in #824 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We changed our file format with the 0.18.0 release series - unfortunately our code still seems to want to read the old file format and then break ;) We gotta be more careful there. I don't think we need to be able to read all old versions of files but I think we should rather capture the error and continue without processing the old results (easiest to achieve I believe).
This is my preliminary diagnosis, problems goes away when deleting the
coverage
directory.Reported by @klyonrad #781 (comment)
#781
The text was updated successfully, but these errors were encountered: