Fix root_filter evaluates SimpleCov.root before initialization.

[tmtm]

If SimpleCov.root is set to other directory, but root_filter uses current directory.

require 'simplecov'
SimpleCov.root '/other/directory'
obj = Struct.new(:filename).new('/other/directory/test.rb')
p SimpleCov.filters.any?{ |filter| filter.matches? obj }
#=> returns true but it should be false.

[bfontaine]

It’s unrelated to this PR, but this could be simplified into src.filename !~ root_filter.

[colszowka]

You're right - if you like please send in a PR ❤️

[MikeMcQuaid]

CC @colszowka for thoughts as we're using a patched version of simplecov in Homebrew to workaround this issue. Thanks for your great work on this gem!

[UniqMartin]

Just to add a bit more context: This fixes a regression in 0.11.0 and above introduced by #396.

[colszowka]

Makes sense, thanks!

[colszowka]

@MikeMcQuaid Thank you. We've been collecting a bunch of enhancements and now this bugfix, I'll try to get v0.11.2 out over the weekend - I want to go over the other open PRs and check if we can get those in too. Please complain if it's not out by Monday.

[MikeMcQuaid]

@colszowka Haha, thanks! The other one we (Homebrew) care about is #436; it'd be great if that (or the patch @bfontaine suggested) could make it in (although I know there's merge conflicts on the PR itself...)

[bfontaine]

Please complain if it's not out by Monday.

It’s Monday and it’s not out 😄

[colszowka]

Yip, sorry about that, didn't find the time to properly look into that other pending PR over the weekend since it apparently needs properly reading the source (there is a seemingly legit complaint in there regarding changed behavior)

Either I get that figured out or I'll ship an intermediate 0.11.2 first, then get that sorted and let 0.11.3 follow closely

[bfontaine]

@colszowka Don’t worry about the time it takes 😃

[colszowka]

So, 0.11.2 is out now, I'll try to get the merging thing figured out and let a 0.11.3 follow as soon as possible!

[bfontaine]

Thank you!