Add method to shutdown and collect results before at_exit #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove explicit JSON dependency
…esult to false which will prevent from running again at_exit
# Conflicts: # simplecov.gemspec
|
@colszowka I can add a test for this new method, wanted to check if you were ok with the general premise first though |
|
👋 Hi there, sorry for the delay I've been rather busy :) What's you use case if I might ask? It's rather specific. To understand if there'd be a better way to do this/accomplish this I need to understand the use case. |
PragTob
reviewed
Jul 20, 2019
| SimpleCov.set_exit_exception | ||
| exit_status = SimpleCov.exit_status_from_exception | ||
| SimpleCov.result.format! | ||
| exit_status = SimpleCov.process_result(SimpleCov.result, exit_status) |
There was a problem hiding this comment.
I think SimpleCov should be self here so no need to address it directly imo. Also I think the last assignment and return aren't needed :)
| @@ -53,6 +53,17 @@ def start(profile = nil, &block) | |||
| Coverage.start | |||
| end | |||
|
|
|||
| # | |||
| # Method added by NREL to shutdown SimpleCov and collect results | |||
|
@macumber Hi there! 👋 Any plans on picking this up or detailing your use case for this? Would be really helpful! :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using simplecov as part of a testing framework and have need to collect results before
at_exit. The newend_nowmethod allows the user to get results beforeat_exit.