Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note how to use simplecov with knapsack_pro gem #822

Merged
merged 3 commits into from
Jan 12, 2020

Conversation

ArturT
Copy link
Contributor

@ArturT ArturT commented Jan 12, 2020

I often get asked by users of my knapsack_pro gem how to make simplecov working with my tool. I noticed you have a section for Notes on specific frameworks and test utilities so I've created this PR. Let me know if this looks ok.

Here is preview:
https://github.com/ArturT/simplecov/tree/note-knapsack#notes-on-specific-frameworks-and-test-utilities

Copy link
Collaborator

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there and thanks a lot! 👌

Looks good, although I wonder a bit how the merging actually works then and if it's accurate/how it's accurate - seems like after getting them all together one simplecov process would have to run to get the correct result but I'm not familiar enough with knapsack.

One way or another, this is an improvement so thank you very much!

bunnies

@PragTob PragTob merged commit f1b7668 into simplecov-ruby:master Jan 12, 2020
@ArturT
Copy link
Contributor Author

ArturT commented Jan 12, 2020

Merging simplecov reports depends a lot on CI providers. Some CI servers would allow you to preview reports in web UI if you store results as assets. You can also use CodeClimate to convert simplecov report and send to CodeClimate.
https://knapsackpro.com/faq/question/how-to-use-codeclimate-with-knapsack_pro

I'm wondering about creating some more general solution but it would require to store reports somewhere. Maybe a simple bash script to send reports temporarily to S3 and later merge by the last executed parallel job.

I've updated my FAQ to also mention that you could use CodeClimate to merge reports.

@PragTob Thanks for merging PR.

@PragTob
Copy link
Collaborator

PragTob commented Jan 13, 2020

@ArturT I wouldn't necessarily use code climate for the merging. Not sure how much merging of reports they do, plus reportedly at elast when running with parallel tests their results can be off from what we do which lies in the way they integrate with simplecov (through an internal undocumented file)

What you say is exactly what I'd recommend - send the intermediate files to some commonly accessible location and then let the last one/a final process merge them together. @ticky and @deivid-rodriguez have been working on a solution to include into simplecov for that, see: #780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants