Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regions ADR (architecture decision record) #1381

Merged
merged 7 commits into from
Mar 9, 2021
Merged

Conversation

rsanheim
Copy link
Contributor

@rsanheim rsanheim commented Oct 1, 2020

Story card: ch2440

Because

Our Regions model is a large change, and could use some explanation, even after the fact 😁 . This adds a retroactive architecture decision record to help explain some of the context, motivation, and tradeoffs around our move to the Regions model.

@harimohanraj89 harimohanraj89 temporarily deployed to simple-review-pr-1381 October 1, 2020 13:56 Inactive
@github-actions
Copy link
Contributor

This PR is stale. Please review/update it or close it.

@kitallis
Copy link
Contributor

kitallis commented Dec 9, 2020

Re-opening this.

@kitallis kitallis reopened this Dec 9, 2020
@kitallis kitallis removed the stale-pr label Dec 9, 2020
@github-actions
Copy link
Contributor

This PR is stale. Please review/update it or close it.

@github-actions github-actions bot closed this Dec 27, 2020
@kitallis kitallis reopened this Jan 4, 2021
@kitallis kitallis removed the stale-pr label Jan 4, 2021
@harimohanraj89 harimohanraj89 temporarily deployed to simple-review-pr-1381 January 4, 2021 06:08 Inactive
@github-actions
Copy link
Contributor

This PR is stale. Please review/update it or close it.

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #2440: Document a Regions ADR.

@rsanheim rsanheim deleted the add-regions-adr branch March 9, 2021 04:43
@rsanheim rsanheim restored the add-regions-adr branch March 9, 2021 04:43
@rsanheim rsanheim reopened this Mar 9, 2021
@harimohanraj89 harimohanraj89 temporarily deployed to simple-review-pr-1381 March 9, 2021 06:43 Inactive
@rsanheim rsanheim temporarily deployed to simple-review-pr-1381 March 9, 2021 06:51 Inactive
@rsanheim rsanheim requested a review from a team March 9, 2021 06:58
@rsanheim rsanheim marked this pull request as ready for review March 9, 2021 07:12
Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this was helpful to me. I was just looking at Regions yesterday and realized I don't understand how we handle regions, facilities, and districts. This sheds a bit of light.


Our mobile app sync has been built around FacilityGroup. As we have grown, syncing all patients within a FacilityGroup loads far too much data -- sometimes tens of thousands of patients. This can overload mobile phones and introduce many UX challenges. Most Simple app users work with hundreds or maybe a thousand of patients over the course of a week, not 10k+.

In the admin UI, there are many users who want to monitor performance at differnt levels than the district or facility level. Some admin users should have access to levels above or below the FacilityGroup that do not yet exist. For example, in India some users should have reports access at the [state level](https://en.wikipedia.org/wiki/States_and_union_territories_of_India), which is above the district (ie FacilityGroup). The current model does not suppor this, in any sort of clean way.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typos here: differnt and suppor

@rsanheim rsanheim temporarily deployed to simple-review-pr-1381 March 9, 2021 18:45 Inactive
@rsanheim rsanheim temporarily deployed to simple-review-pr-1381 March 9, 2021 22:20 Inactive
@rsanheim rsanheim merged commit b498e6b into master Mar 9, 2021
@rsanheim rsanheim deleted the add-regions-adr branch March 9, 2021 22:28
@rsanheim rsanheim changed the title Regions ADR Regions ADR (architecture decision record) Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants