Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support emails value filtering without value property #11

Closed
spencerkittleson opened this issue Nov 12, 2019 · 2 comments
Closed

Support emails value filtering without value property #11

spencerkittleson opened this issue Nov 12, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@spencerkittleson
Copy link

Currently filtering by user emails without property doesn't work. It be appended with .value to work properly.

See: https://tools.ietf.org/html/rfc7644#section-3.4.4.2
RFC Example: userType eq "Employee" and (emails co "example.com" or emails.value co "example.org")

Or simply: emails co \"example.com\"

Tests found here:

SimpleIdServer/tests/SimpleIdServer.Scim.Tests/FilterFixture.cs

Line 12 in 0d5ca54

public void When_Parse_And_Execute_Filter()

@simpleidserver simpleidserver added the bug Something isn't working label Nov 12, 2019
@simpleidserver
Copy link
Owner

The issue has been moved to the next release

@simpleidserver simpleidserver mentioned this issue Nov 15, 2019
Closed
thabart added a commit that referenced this issue Nov 16, 2019
@thabart
Ticket #10 #11 #12 : Allows quotes + supports mails value filtering w…
9455753 
…ithout value property + correctly parse grouping filter + add license header
@simpleidserver
Copy link
Owner

simpleidserver commented Nov 16, 2019 •
edited
Loading

The bug is fixed in branch release/1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simpleidserver @spencerkittleson