Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCIM Attribute Data Types #48

Closed
boris-meerovich-sp opened this issue Sep 24, 2020 · 11 comments
Closed

SCIM Attribute Data Types #48

boris-meerovich-sp opened this issue Sep 24, 2020 · 11 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@boris-meerovich-sp
Copy link

Hi,
I'm wondering how can I set attributes values to decimal numbers or binary data?
According to SCIM RFC there is decimal and binary values should be supported.
In SCIMRepresentationAttribute class there are only:

  • string
  • bool
  • int
  • DateTime

Also, how can I set null to ValuesDateTime property?
Maybe it should be define as
public ICollection<DateTime?> ValuesDateTime { get; set; }

Please, advise

@simpleidserver
Copy link
Owner

Hi,

Indeed the Decimal and Binary types are not supported, we will include them in the next release (v1.1.7).

Why do you want to set null to ValuesDateTime property ?
If the SCIM representation doesn't contain valid DateTime property then the collection ValuesDateTime will be empty.

@boris-meerovich-sp
Copy link
Author

Hi,
Thanks for the quick reply!!!
This is good news according to the next release? What's the time estimation for v1.1.7?

I've tried to add DateTime property with empty value, but got exception in SCIMRepresentationExtensions.cs (row:444)
System.InvalidOperationException: 'Sequence contains no elements'
for representationAttr.ValuesDateTime.First() code...

The ValuesDateTime field is empty, thus the exception is thrown.
I need that the DateTime field value will be null or empty...

@simpleidserver
Copy link
Owner

We are going to investigate your problem.
The next release will be ready next week (29 september).

@boris-meerovich-sp
Copy link
Author

Thanks!!!

@abhishekkandi
Copy link

abhishekkandi commented Sep 25, 2020

@simpleidserver Can you guys provide add user, update group samples?? Having a hard time to find one. Checked the documentation too.

Also can we use this package to make external system SCIM calls??

@simpleidserver simpleidserver self-assigned this Sep 25, 2020
@simpleidserver simpleidserver added enhancement New feature or request bug Something isn't working labels Sep 25, 2020
thabart added a commit that referenced this issue Sep 25, 2020
@simpleidserver
Copy link
Owner

@abhishekkandi : We don't provide a client to make HTTP request against the SCIM endpoint.
You can find samples in the acceptance test project : https://github.com/simpleidserver/SimpleIdServer/blob/master/tests/SimpleIdServer.Scim.Host.Acceptance.Tests/Features/Users.feature. For example, the first scenario describes how to create a user.

Otherwise, we add some samples in the directory : https://github.com/simpleidserver/SimpleIdServer/tree/release/1.1.7/src/Scim/FiddleRequests

@simpleidserver
Copy link
Owner

@boris-meerovich-sp A pre-released version of the SCIM project has been published. Can-you please check if you still have the exception ? The types "binary" and "decimal" are now supported.
The nuget package is here : https://www.myget.org/feed/advance-ict/package/nuget/SimpleIdServer.Scim (version 1.1.7-ci-00146)

@abhishekkandi
Copy link

abhishekkandi commented Sep 25, 2020

@simpleidserver Can you suggest me any scim client nuget packages. If you know one.

@simpleidserver
Copy link
Owner

I don't know a valid SCIM client.
We can write one if we have some times (ticket : #49)

@abhishekkandi
Copy link

Thanks, @simpleidserver. That'd be great not just to me but many other fellow developers.

@boris-meerovich-sp
Copy link
Author

boris-meerovich-sp commented Sep 29, 2020

@simpleidserver I checked the new pre-released version and here are my conclusions:

  • Can add decimal/binary data types
  • Decimal values: Can you please add to SCIMSchemaAttributeBuilder.cs AddDecimalAttribute() method?
  • DateTime: Empty values collection exception is not thrown anymore

Thanks for a quick fix!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants