Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for certificate validation by fingerprint #68

Closed
thijskh opened this issue Aug 5, 2016 · 1 comment · Fixed by #153
Closed

Remove support for certificate validation by fingerprint #68

thijskh opened this issue Aug 5, 2016 · 1 comment · Fixed by #153
Labels
enhancement
Milestone
v4.0

Comments

@thijskh
Copy link
Member

thijskh commented Aug 5, 2016

The library allows one to configure trusted certificates either in full, or with just the fingerprint. These two ways of working complicate the code significantly, while the advantage of using fingerprints seems marginal. We should therefore transition to only accept full certificates.

Discussion at https://groups.google.com/forum/#!topic/simplesamlphp-dev/MTbTGxAWniw
thijskh added a commit to thijskh/saml2 that referenced this issue Aug 5, 2016
@thijskh
Add deprecation tags to classes and methods that work with certificat…
1336dd1 
…e fingerprints.

See simplesamlphp#68
This was referenced Aug 5, 2016
Merged
Closed
@thijskh
Copy link
Member Author

thijskh commented Aug 5, 2016

See simplesamlphp/simplesamlphp#431 for the simpleSAMLphp part.

thijskh added a commit to thijskh/saml2 that referenced this issue Aug 5, 2016
@thijskh
Add deprecation tags to classes and methods that work with certificat…
d1680d3 
…e fingerprints.

See simplesamlphp#68
@tvdijen tvdijen mentioned this issue Jan 17, 2019
Merged
@tvdijen tvdijen added this to the v4.0 milestone Jan 17, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

Remove deprecated functionality simplesamlphp/saml2
2 participants
@tvdijen @thijskh