Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Conditions/AudienceRestriction/Audience in AuthnRequest #137

Merged
merged 4 commits into from
Nov 23, 2018
Merged

Support for Conditions/AudienceRestriction/Audience in AuthnRequest #137

merged 4 commits into from
Nov 23, 2018

Conversation

bjorpe
Copy link

@bjorpe bjorpe commented Nov 22, 2018

To support implementation of Conditions/AudienceRestriction/Audience in simplesamlphp, see simplesamlphp/simplesamlphp#201

@bjorpe bjorpe mentioned this pull request Nov 22, 2018
Merged
@coveralls
Copy link

coveralls commented Nov 22, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 69.846% when pulling df18268 on bjorpe:master into 2330914 on simplesamlphp:master.

thijskh
thijskh previously requested changes Nov 22, 2018
View reviewed changes
Copy link
Member

@thijskh thijskh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this looks sane. However, it lacks unit tests. Any new code should be covered by tests, in this case 100% coverage of the new lines should be very feasible to achieve.

@bjorpe
Copy link
Author

bjorpe commented Nov 23, 2018

Tests added! Also added support for parsing audiences from xml for completeness.

@tvdijen tvdijen dismissed thijskh’s stale review November 23, 2018 10:01

Tests have been added by contributor

@tvdijen
Copy link
Member

tvdijen commented Nov 23, 2018

Thanks @bjorpe, a solid PR that's very useful!

@thijskh thijskh merged commit 30e9c1b into simplesamlphp:master Nov 23, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thijskh thijskh thijskh approved these changes

@tvdijen tvdijen tvdijen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjorpe @coveralls @tvdijen @thijskh