Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getter/setter methods to replace public properties #143

Merged
merged 5 commits into from
Dec 1, 2018
Merged

Conversation

tvdijen
Copy link
Member

@tvdijen tvdijen commented Nov 29, 2018

The properties will for now remain public. They will be marked private in 4.0

Closes #141

@coveralls
Copy link

coveralls commented Nov 29, 2018

Coverage Status

Coverage increased (+0.2%) to 70.469% when pulling 472f27c on gettersetter into fd63b10 on master.

@tvdijen tvdijen force-pushed the gettersetter branch 3 times, most recently from 44c4080 to 6d6355d Compare December 1, 2018 12:56
tvdijen and others added 2 commits December 1, 2018 16:37
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
@tvdijen tvdijen force-pushed the gettersetter branch 2 times, most recently from d29e7c6 to a659210 Compare December 1, 2018 16:41
@tvdijen tvdijen merged commit 23823fa into master Dec 1, 2018
@tvdijen tvdijen deleted the gettersetter branch December 1, 2018 21:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public properties need to be replaced with getter/setter methods
3 participants