Make processor aware of assertion types #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
============================================
+ Coverage 87.84% 87.97% +0.12%
- Complexity 2404 2406 +2
============================================
Files 166 166
Lines 6016 6020 +4
============================================
+ Hits 5285 5296 +11
+ Misses 731 724 -7 |
MKodde
force-pushed
the
feature/integrate-processor-change
branch
3 times, most recently
from
74af94c to
6381665
Compare
tvdijen
approved these changes
Aug 19, 2020
|
It's a nitpick, but could you add a bunch of use-statements to the test-file and squash the full namespaced class names? |
|
Absolutely. I thought the team preferred having less import statements in favor of instant readability what namespace a class hails from? |
Both the Encrypted and regular Assertion classes should be passable in the decryptAssertion method. If not, you would never be able to process a SAML Response consisting of regular Assertion objects. The test merely verifies the behaviour that was changed in this commit. No additional processor tests where added. But that should be simple enough in the future. For some odd reason using a data provider for the processor_correctly_encrypts_assertions caused issues in other tests. The test suite does not seem to be fully idempotent.
MKodde
force-pushed
the
feature/integrate-processor-change
branch
from
6381665 to
bd1fe04
Compare
|
I've noticed that some of the analyzer tools do a better job with the use-statements in place.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates #240 into
master