Bump xmlseclibs version

[chris1312]

#97

[coveralls]

Coverage remained the same at 67.553% when pulling 3d0e659 on chris1312:master into 3c5f58c on simplesamlphp:master.

[thijskh]

If you also bump the composer.lock then Travis can show us whether the testsuite still passes (spoiler: it does).

[chris1312]

Sorry, I did not catch..

This project does not contain composer.lock. Do you say that you want me to commit composer.lock into the project? I see in Travis build (e.g. for PHP7) that the 3.0.0 version of xmlseclibs was installed.

[thijskh]

Indeed, my mistake. The tests pass, that's a good start!

[chris1312]

Is there anything more you expect from this pull request?

[thijskh]

Not per se, just need to find some time to do some further testing, then merge.

[jaimeperez]

Hi @chris1312!

I would also like to see how the discussion in robrichards/xmlseclibs#123 ends up before we trust the 3.0.0 to be stable and final. I'm afraid of bumping the version here to see days afterwards that it was removed to merge that PR instead.

That said, I'm really looking forward to this myself too...

[chris1312]

OK, sure!

[thijskh]

@jaimeperez Those two pr's are functionally the same, right? So would it matter much to change later?

[jaimeperez]

Nah, I don't think there'll be changes to the code (not significantly anyway). I'm just afraid of some kind of mess if Rob tries to fix it so that proper credit is given to the code by merging the existing PR, but he doesn't seem to be responsive at all, and if something breaks, we can always fix it.

So given that we are in master here, 👍 from me too.

[thijskh]

Thanks for your contribution!