Skip to content

Commit

Permalink
Remove unnecessary toXML/fromXML
Browse files Browse the repository at this point in the history
  • Loading branch information
tvdijen committed Dec 26, 2023
1 parent 7d0c0ba commit ed99739
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tests/XML/AbstractElementTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function testMarshalling(): void

/**
*/
#[Override]
#[\Override]
public function testUnmarshalling(): void

Check failure on line 58 in tests/XML/AbstractElementTest.php

View workflow job for this annotation

GitHub Actions / Unit tests, PHP 8.3, ubuntu-latest

SimpleSAML\Test\XML\AbstractElementTest::testUnmarshalling() has #[\Override] attribute, but no matching parent method exists

Check failure on line 58 in tests/XML/AbstractElementTest.php

View workflow job for this annotation

GitHub Actions / Unit tests, PHP 8.3, windows-latest

SimpleSAML\Test\XML\AbstractElementTest::testUnmarshalling() has #[\Override] attribute, but no matching parent method exists
{
$element = Element::fromXML(self::$xmlRepresentation->documentElement);
Expand Down
2 changes: 1 addition & 1 deletion tests/XML/Base64ElementTraitTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function testMarshalling(): void

/**
*/
#[Override]
#[\Override]
public function testUnmarshalling(): void
{
$base64Element = Base64Element::fromXML(self::$xmlRepresentation->documentElement);
Expand Down
2 changes: 1 addition & 1 deletion tests/XML/ChunkTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public function testMarshalling(): void

/**
*/
#[Override]
#[\Override]
public function testUnmarshalling(): void
{
$element = Chunk::fromXML(self::$xmlRepresentation->documentElement);
Expand Down

0 comments on commit ed99739

Please sign in to comment.