Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.2.3 #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Release/2.2.3 #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d08f525
Fix Cannot read property 'context' of undefined in update callback
silverspectro Jun 26, 2018
35f50ba
Merge pull request #1 from silverspectro/feature/context-not-defined
silverspectro Jun 26, 2018
6613d1c
update package.json version & update CHANGELOG
silverspectro Jun 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dist/vue-clickaway.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function bind(el, binding, vnode) {
}, 0);

el[HANDLER] = function(ev) {
// @NOTE: this test used to be just `el.containts`, but working with path is better,
// @NOTE: this test used to be just `el.contains`, but working with path is better,
// because it tests whether the element was there at the time of
// the click, not whether it is there now, that the event has arrived
// to the top.
Expand All @@ -67,9 +67,9 @@ function unbind(el) {

var directive = {
bind: bind,
update: function(el, binding) {
update: function(el, binding, vnode) {
if (binding.value === binding.oldValue) return;
bind(el, binding);
bind(el, binding, vnode);
},
unbind: unbind,
};
Expand Down
4 changes: 2 additions & 2 deletions dist/vue-clickaway.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@

var directive = {
bind: bind,
update: function(el, binding) {
update: function(el, binding, vnode) {
if (binding.value === binding.oldValue) return;
bind(el, binding);
bind(el, binding, vnode);
},
unbind: unbind,
};
Expand Down
2 changes: 1 addition & 1 deletion dist/vue-clickaway.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ function bind(el, binding, vnode) {
}, 0);

el[HANDLER] = function(ev) {
// @NOTE: this test used to be just `el.containts`, but working with path is better,
// @NOTE: this test used to be just `el.contains`, but working with path is better,
// because it tests whether the element was there at the time of
// the click, not whether it is there now, that the event has arrived
// to the top.
Expand All @@ -64,9 +64,9 @@ function unbind(el) {

export var directive = {
bind: bind,
update: function(el, binding) {
update: function(el, binding, vnode) {
if (binding.value === binding.oldValue) return;
bind(el, binding);
bind(el, binding, vnode);
},
unbind: unbind,
};
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "vue-clickaway",
"description": "Reusable clickaway directive for reusable Vue.js components",
"version": "2.2.2",
"version": "2.2.3",
"author": "Denis Karabaza <denis.karabaza@gmail.com>",
"browserify": {
"transform": [
Expand Down