agent: fix performance leak, smp server: optimize and fix potential memory leak #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
epoberezkin
commented
Feb 20, 2024
•
epoberezkin
commented
- Fix performance degradation when re-connecting SMP clients (see comment in Simplex.Messaging.Agent.Client).
- Only make active subscriptions pending if the disconnected client was current (check and change are in one STM transaction).
- Remove unused timeoutPerBlock.
- smp server:
- determine that client is the same based on client ID (faster comparison).
- more efficient processing of removing subscriptions when client disconnects (replace STM loop with pure fold).
- track and remove threads for END delivery when client disconnects to avoid them hanging in case of two many ENDs not fitting the queue preventing the client from being GCd.
epoberezkin
force-pushed
the
ep/fix-performance-leak
branch
from
7559993 to
7325a35
Compare
epoberezkin
changed the title
epoberezkin
force-pushed
the
ep/fix-performance-leak
branch
from
9a69147 to
fa21d50
Compare
epoberezkin
force-pushed
the
ep/fix-performance-leak
branch
from
fa21d50 to
0bf8dce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.