Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker improvements #1142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

romeobuilderotti
Copy link

@romeobuilderotti romeobuilderotti commented May 10, 2024

  • Added Docker Compose file and docs. Usually this way it's easier to start and manage than plain docker.
  • Removed apt cache from the image, reducing its size
  • Added --no-install-recommends that prevents adding extra recommended packages to the install list (and added ca-certificates package explicitly). This one might lead to errors if some required package is not explicitly installed but was in the recommended list of some other package. I've verified that current branch images successfully build and run, but this might require further testing. In any case it's better to specify any dependencies explicitly rather than relying on recommended packages.

Further improvements:

  • Consider using alpine base image to considerably reduce image size.
  • docker-compose.yml allows to add a TOR service using something similar to strm/tor. Easier setup will lead more users to run a TOR compatible queue in deployments by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant