Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMP commands for notifications (NKEY/NID and NSUB/NMSG) with separate queue ID and key #199

Merged
merged 19 commits into from
Nov 14, 2021
Merged

SMP commands for notifications (NKEY/NID and NSUB/NMSG) with separate queue ID and key #199

merged 19 commits into from
Nov 14, 2021

Conversation

epoberezkin
Copy link
Member

No description provided.

@epoberezkin epoberezkin marked this pull request as draft October 31, 2021 18:53
@epoberezkin epoberezkin changed the title SMP commands for notifications (LSTN, NTFY) with separate queue IDs and keys SMP commands for notifications (NSUB, NKEY, NMSG) with separate queue IDs and keys Nov 13, 2021
@epoberezkin epoberezkin changed the title SMP commands for notifications (NSUB, NKEY, NMSG) with separate queue IDs and keys SMP commands for notifications (NSUB, NKEY, NMSG) with separate queue ID and key Nov 13, 2021
@epoberezkin epoberezkin force-pushed the ep/notifications branch 3 times, most recently from ad5cc52 to 0189798 Compare November 13, 2021 09:24
@epoberezkin epoberezkin marked this pull request as ready for review November 13, 2021 14:00
@epoberezkin epoberezkin changed the title SMP commands for notifications (NSUB, NKEY, NMSG) with separate queue ID and key SMP commands for notifications (NKEY/NID and NSUB/NMSG) with separate queue ID and key Nov 13, 2021
spaced4ndy
spaced4ndy approved these changes Nov 14, 2021
View reviewed changes
Copy link
Collaborator

@spaced4ndy spaced4ndy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix comment before merging

epoberezkin and others added 3 commits November 14, 2021 18:28
@epoberezkin @spaced4ndy
Update src/Simplex/Messaging/Client.hs
2a11e5f 
Co-authored-by: Efim Poberezkin <8711996+efim-poberezkin@users.noreply.github.com>
@epoberezkin @spaced4ndy
Update src/Simplex/Messaging/Server.hs
4097ebf 
Co-authored-by: Efim Poberezkin <8711996+efim-poberezkin@users.noreply.github.com>
@epoberezkin
store log: s/NOTIFY/NOTIFIER/
69724db
@epoberezkin epoberezkin merged commit 227d83d into v5 Nov 14, 2021
@epoberezkin epoberezkin deleted the ep/notifications branch November 14, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaced4ndy spaced4ndy spaced4ndy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epoberezkin @spaced4ndy