Correct minor Docker syntax error #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed that the environment variables for SMP server when using Docker were improperly quoted, so I corrected them. This will fix an issue with server address being displayed incorrectly in the CLI when viewing init logs. I also explicitly added the `:latest` tag for the Docker image in the Running example to make it more clear which tag is being run (no tag defaults to `latest`.)
|
LGTM, thanks for correcting the docs. |
|
@sethforprivacy thank you! |
|
Thank you all for the excellent docs, made getting an SMP server up and running a breeze! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the environment variables for SMP server when using Docker were improperly quoted, so I corrected them.
This will fix an issue with server address being displayed incorrectly in the CLI when viewing init logs.
I also explicitly added the
:latesttag for the Docker image in the Running example to make it more clear which tag is being run (no tag defaults tolatest.)