Support for building ARM docker images #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 9, 2023 20:25
the current haskell is hardcoded to x86, so switch to using haskell’s official helper script which supports arm also need to bump up setting the path, since ghcup is no longer in /usr/bin reference: https://www.haskell.org/ghcup/guide/#continuous-integration
docker build (specifically haskell install step) would fail with : #7 107.2 utils/ghc-cabal/dist-install/build/tmp/ghc-cabal: error while loading shared libraries: libnuma.so.1: cannot open shared object file: No such file or directory I think this is because numa isn’t installed on arm instances of focal by default, but it is in later versions anyway this fixes that
The image builds at this point! But it fails to boot on arm - again with a numa error. This fixes that.
ghost
requested a review
from 
|
Other than small nitpick, LGTM. Thanks for your contribution! |
shumvgolove
requested changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Docker images are x86_64/amd64 only. This PR enables ARMv8 images to easily be built. Currently only tested building ARM images on Apple Silicon, but I tested the generated images on both a Raspberry Pi 4 and M1 Pro, in other words you can now run SimpleXMQ using docker on Raspberry Pi and Apple Silicon machines (and others?).
I also confirmed that this doesn't break existing x86_64 builds - although I only tested on 64-bit Ubuntu 22.04.2
A test artifact can be found on Docker's registry
docker pull shyfire131/smp-server-armThe commits have been split up and should be self explanatory.
Should fix #678
Hopefully this will also enable you guys to publish arm images to Docker Hub?