Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for server renames, improve server time handling #99

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

derklaro
Copy link
Contributor

The top navigation shows the date and time on the server. However, some servers are not using the current date, e.g. de1 is 2 days ahead while de3 is still in october 2024. To actually display that the server timezone are no longer hours, but rather the offset seconds from UTC. This displays the time & date correctly.

DE1:
image

DE3:
image

@derklaro
Copy link
Contributor Author

Gonna mark this as draft for now: some servers will change tomorrow and it seems like some server times are reported wrong by the api currently (SimRail team will check tomorrow).

@derklaro derklaro marked this pull request as draft January 13, 2025 22:51
@derklaro
Copy link
Contributor Author

Should be correct and ready now

@derklaro derklaro marked this pull request as ready for review January 14, 2025 10:14
@derklaro
Copy link
Contributor Author

Also fixes two other issues with the server change:

  1. International servers now use the International Flag of Planet Earth which seems to be the best international choice right now (there doesn't seem to be any internationally recognised flags for the earth). The version used on the map is a manual recreation from the original, so it doesn't look 100% like the original:
image
  1. Long server names are expanding into the favorite star icon, this is also fixed
image image

@derklaro derklaro changed the title change server timezone handling to utc offset seconds update for server renames, improve server time handling Jan 14, 2025
@ShiralynDev
Copy link
Contributor

I was a bit late to the game, this was my implementation
image

Copy link
Member

@Julian-Louis Julian-Louis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution !

@Julian-Louis Julian-Louis merged commit 911af3b into simrail:main Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants