Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

added resend email sender in place of existing mail sender

Type of Change

  • New feature

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Sep 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Canceled Canceled Sep 23, 2025 1:45am
sim Ready Ready Preview Comment Sep 23, 2025 1:45am

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR replaces the existing internal mail service with a Resend-based email integration. The changes migrate from a centralized email service to a user-managed approach where users provide their own Resend API keys and from addresses.

Key Changes:

  • Tool Migration: Replaced mail_send tool with resend_send tool, requiring users to provide resendApiKey and fromAddress parameters
  • Block Update: Created new ResendBlock to replace MailBlock, with updated configuration and parameter requirements
  • API Route Changes: Modified /api/tools/mail/send route to accept and use user-provided Resend credentials instead of internal email service
  • Documentation Updates: Removed old mail tool documentation across multiple languages and added comprehensive Resend documentation
  • Icon Addition: Added ResendIcon component for UI integration
  • Registry Updates: Updated tool and block registries to reference the new Resend implementations
  • Environment Cleanup: Removed MAIL_BLOCK_FROM_ADDRESS environment variable as it's now handled via tool parameters

The migration maintains the same API endpoint structure (/api/tools/mail/send) to minimize breaking changes, while the backend now uses the Resend SDK. This architectural shift moves from OAuth-based complexity to API-key simplicity, giving users direct control over their email sending infrastructure while potentially improving deliverability through Resend's specialized email service.

Confidence score: 2/5

  • This PR introduces significant security and functionality risks that require careful review before merging
  • Score reflects concerns about API key handling in request bodies, incomplete documentation removal, and potential breaking changes for existing workflows
  • Pay close attention to the API route handler, documentation gaps, and the security implications of transmitting API keys in request bodies

18 files reviewed, 8 comments

Edit Code Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants