-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(tools): added resend email sender #1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR replaces the existing internal mail service with a Resend-based email integration. The changes migrate from a centralized email service to a user-managed approach where users provide their own Resend API keys and from addresses.
Key Changes:
- Tool Migration: Replaced
mail_sendtool withresend_sendtool, requiring users to provideresendApiKeyandfromAddressparameters - Block Update: Created new
ResendBlockto replaceMailBlock, with updated configuration and parameter requirements - API Route Changes: Modified
/api/tools/mail/sendroute to accept and use user-provided Resend credentials instead of internal email service - Documentation Updates: Removed old mail tool documentation across multiple languages and added comprehensive Resend documentation
- Icon Addition: Added
ResendIconcomponent for UI integration - Registry Updates: Updated tool and block registries to reference the new Resend implementations
- Environment Cleanup: Removed
MAIL_BLOCK_FROM_ADDRESSenvironment variable as it's now handled via tool parameters
The migration maintains the same API endpoint structure (/api/tools/mail/send) to minimize breaking changes, while the backend now uses the Resend SDK. This architectural shift moves from OAuth-based complexity to API-key simplicity, giving users direct control over their email sending infrastructure while potentially improving deliverability through Resend's specialized email service.
Confidence score: 2/5
- This PR introduces significant security and functionality risks that require careful review before merging
- Score reflects concerns about API key handling in request bodies, incomplete documentation removal, and potential breaking changes for existing workflows
- Pay close attention to the API route handler, documentation gaps, and the security implications of transmitting API keys in request bodies
18 files reviewed, 8 comments
7d8cbc4 to
9336dd2
Compare
9336dd2 to
7bd0dfa
Compare
Summary
added resend email sender in place of existing mail sender
Type of Change
Testing
Tested manually
Checklist