Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

added japanese and german translations

Type of Change

  • New feature

Testing

N/A

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Sep 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Sep 23, 2025 10:16pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
sim Skipped Skipped Sep 23, 2025 10:16pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR adds Japanese and German translation support to the documentation system. The changes systematically update all i18n configuration points including the language dropdown UI, fumadocs configuration, Lingo.dev translation targets, and GitHub workflow automation.

Key Changes:

  • Added Japanese (🇯🇵) and German (🇩🇪) to the language dropdown component
  • Enhanced dropdown with better accessibility features (ARIA attributes, keyboard navigation)
  • Updated i18n configuration to include ja and de in supported languages
  • Modified GitHub workflow to track and report translation coverage for new languages
  • Improved navigation using Next.js router instead of direct window.location changes

Minor Issues:

  • Language ordering inconsistency between components (dropdown vs config files)
  • Otherwise, changes are comprehensive and well-integrated across the entire i18n system

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - adds new language support with proper configuration
  • Score reflects comprehensive and systematic changes across all i18n touchpoints. Minor style issue with language ordering doesn't affect functionality.
  • Minor attention needed for apps/docs/components/ui/language-dropdown.tsx for language ordering consistency

Important Files Changed

File Analysis

Filename        Score        Overview
.github/workflows/i18n.yml 5/5 Updated automation workflow to support Japanese and German translations with proper coverage tracking
apps/docs/components/ui/language-dropdown.tsx 4/5 Enhanced language dropdown with Japanese and German support, improved accessibility and navigation behavior
apps/docs/i18n.json 5/5 Added Japanese (ja) and German (de) to translation targets configuration for Lingo.dev
apps/docs/lib/i18n.ts 5/5 Updated fumadocs i18n configuration to include German and Japanese language support

Sequence Diagram

sequenceDiagram
    participant User
    participant LanguageDropdown
    participant Router
    participant I18nConfig
    participant LingoWorkflow
    participant DocsContent

    User->>LanguageDropdown: Select language (ja/de)
    LanguageDropdown->>LanguageDropdown: handleLanguageChange()
    LanguageDropdown->>Router: router.push(newPath)
    Router->>I18nConfig: Load i18n configuration
    I18nConfig->>DocsContent: Render content in selected language

    Note over LingoWorkflow: Automated Translation Process
    LingoWorkflow->>LingoWorkflow: Detect content changes
    LingoWorkflow->>LingoWorkflow: Generate translations (ja, de)
    LingoWorkflow->>LingoWorkflow: Create PR with translations
    LingoWorkflow->>LingoWorkflow: Generate coverage report
Loading

4 files reviewed, 1 comment

Edit Code Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants