Skip to content

Conversation

@Sg312
Copy link
Contributor

@Sg312 Sg312 commented Sep 25, 2025

Summary

Stop double calling

Fixes #(issue)

Type of Change

  • Bug fix

Testing

Manual

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Sep 25, 2025 7:37pm
sim Building Building Preview Comment Sep 25, 2025 7:37pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR fixes CI workflow duplication by removing redundant push triggers from individual workflow files that were causing the same workflows to run both directly and via workflow_call from the main CI pipeline.

Key Changes:

  • Removed push: branches: [main, staging] triggers from build-ecr.yml, docs-embeddings.yml, and trigger-deploy.yml
  • Added workflow_dispatch triggers to all affected workflows to enable manual execution when needed
  • Removed path-based filtering from docs-embeddings.yml as this is now handled by the main CI workflow

Impact:
The changes ensure workflows only execute once per push through the centralized ci.yml orchestration, eliminating redundant runs while maintaining the ability to manually trigger individual workflows when needed for debugging or maintenance.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects a straightforward infrastructure fix with clear benefits and no logic changes to workflow execution
  • No files require special attention

Important Files Changed

File Analysis

Filename        Score        Overview
.github/workflows/build-ecr.yml 5/5 Removed duplicate push trigger on main/staging branches, now only called via workflow_call from ci.yml, added workflow_dispatch for manual triggering
.github/workflows/build-ghcr-build.yml 5/5 Added workflow_dispatch trigger for manual execution while maintaining workflow_call functionality
.github/workflows/build-ghcr-push.yml 5/5 Added workflow_dispatch trigger for manual execution while maintaining workflow_call functionality
.github/workflows/docs-embeddings.yml 5/5 Removed duplicate push trigger on main/staging with paths filter, now only called via workflow_call from ci.yml, kept workflow_dispatch
.github/workflows/trigger-deploy.yml 5/5 Removed duplicate push trigger on main/staging branches, now only called via workflow_call from ci.yml, added workflow_dispatch for manual triggering

Sequence Diagram

sequenceDiagram
    participant Developer
    participant GitHub
    participant CI as ci.yml
    participant ECR as build-ecr.yml
    participant GHCR_BUILD as build-ghcr-build.yml
    participant GHCR_PUSH as build-ghcr-push.yml
    participant TRIGGER as trigger-deploy.yml
    participant DOCS as docs-embeddings.yml
    
    Note over Developer,GitHub: Push to main/staging branch
    Developer->>GitHub: git push origin main/staging
    GitHub->>CI: Trigger CI workflow
    
    CI->>CI: Run tests and build
    
    par Parallel execution after tests pass
        CI->>ECR: workflow_call build-ecr.yml
        and CI->>GHCR_BUILD: workflow_call build-ghcr-build.yml
        and CI->>TRIGGER: workflow_call trigger-deploy.yml
    end
    
    Note over ECR,TRIGGER: All workflows run in parallel
    ECR->>ECR: Build & push ECR images + Deploy ECS
    GHCR_BUILD->>GHCR_BUILD: Build GHCR images (no push)
    TRIGGER->>TRIGGER: Deploy Trigger.dev
    
    Note over CI,GHCR_PUSH: Wait for ECR deployment completion
    CI->>GHCR_PUSH: workflow_call build-ghcr-push.yml
    GHCR_PUSH->>GHCR_PUSH: Push GHCR images & create manifests
    
    Note over CI,DOCS: Final steps
    CI->>CI: Apply database migrations
    CI->>DOCS: workflow_call docs-embeddings.yml
    DOCS->>DOCS: Process documentation embeddings
Loading

5 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants