Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

use blacksmith for ci

Type of Change

  • Bug fix

Testing

N/A

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Sep 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Sep 26, 2025 0:38am
sim Ready Ready Preview Comment Sep 26, 2025 0:38am

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

Migrated all CI workflows from GitHub Actions standard runners to Blacksmith infrastructure for improved performance. The changes systematically update runner configurations and Docker build actions across 11 workflow files.

  • Updated all runs-on references from ubuntu-latest to blacksmith-4vcpu-ubuntu-2404
  • Replaced Docker setup and build actions with Blacksmith equivalents (useblacksmith/setup-docker-builder@v1 and useblacksmith/build-push-action@v2)
  • Removed GitHub Actions cache configurations (cache-from and cache-to) as Blacksmith handles caching internally
  • Maintained all existing workflow logic, dependencies, and deployment processes

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - it's a straightforward infrastructure migration
  • Score reflects successful systematic migration to Blacksmith with minor performance considerations around removed caching
  • Pay attention to Docker build workflows that removed caching configurations

Important Files Changed

File Analysis

Filename        Score        Overview
.github/workflows/ci.yml 5/5 Changed runner from ubuntu-latest to blacksmith-4vcpu-ubuntu-2404 for test and migrations jobs
.github/workflows/build-ecr.yml 4/5 Migrated to Blacksmith runners and Docker actions, removed GitHub Actions cache configuration
.github/workflows/build.yml 4/5 Replaced Docker setup/build actions with Blacksmith equivalents, removed GitHub Actions caching
.github/workflows/build-ghcr-build.yml 4/5 Updated Docker actions to use Blacksmith versions, removed GitHub Actions cache configuration
.github/workflows/build-ghcr-push.yml 4/5 Migrated runners and Docker actions to Blacksmith, removed caching from build steps

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub
    participant BS as Blacksmith
    participant ECR as AWS ECR
    participant GHCR as GitHub Container Registry
    participant ECS as AWS ECS

    Dev->>GH: Push to main/staging
    GH->>BS: Trigger CI on blacksmith-4vcpu-ubuntu-2404
    
    par Test Phase
        BS->>BS: Run tests with Bun/Node
        BS->>BS: Build application
        BS->>GH: Upload coverage to Codecov
    end
    
    par Docker Build Phase (after tests pass)
        BS->>BS: Build GHCR images (useblacksmith/build-push-action@v2)
        BS->>BS: Build ECR images (useblacksmith/build-push-action@v2)
        BS->>BS: Deploy Trigger.dev
    end
    
    par Push Phase (after ECR deployment)
        BS->>GHCR: Push multi-arch Docker images
        BS->>ECR: Push Docker images
        BS->>ECS: Update ECS services with new images
    end
    
    par Final Phase
        BS->>BS: Run database migrations
        BS->>BS: Process documentation embeddings
    end

    Note over BS: All runners migrated from ubuntu-latest to blacksmith-4vcpu-ubuntu-2404
    Note over BS: Docker actions migrated from standard to useblacksmith/* versions
    Note over BS: GitHub Actions caching removed (now handled by Blacksmith)
Loading

11 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants