-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(ci): use blacksmith for ci #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Summary
Migrated all CI workflows from GitHub Actions standard runners to Blacksmith infrastructure for improved performance. The changes systematically update runner configurations and Docker build actions across 11 workflow files.
- Updated all
runs-onreferences fromubuntu-latesttoblacksmith-4vcpu-ubuntu-2404 - Replaced Docker setup and build actions with Blacksmith equivalents (
useblacksmith/setup-docker-builder@v1anduseblacksmith/build-push-action@v2) - Removed GitHub Actions cache configurations (
cache-fromandcache-to) as Blacksmith handles caching internally - Maintained all existing workflow logic, dependencies, and deployment processes
Confidence Score: 4/5
- This PR is safe to merge with minimal risk - it's a straightforward infrastructure migration
- Score reflects successful systematic migration to Blacksmith with minor performance considerations around removed caching
- Pay attention to Docker build workflows that removed caching configurations
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .github/workflows/ci.yml | 5/5 | Changed runner from ubuntu-latest to blacksmith-4vcpu-ubuntu-2404 for test and migrations jobs |
| .github/workflows/build-ecr.yml | 4/5 | Migrated to Blacksmith runners and Docker actions, removed GitHub Actions cache configuration |
| .github/workflows/build.yml | 4/5 | Replaced Docker setup/build actions with Blacksmith equivalents, removed GitHub Actions caching |
| .github/workflows/build-ghcr-build.yml | 4/5 | Updated Docker actions to use Blacksmith versions, removed GitHub Actions cache configuration |
| .github/workflows/build-ghcr-push.yml | 4/5 | Migrated runners and Docker actions to Blacksmith, removed caching from build steps |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant GH as GitHub
participant BS as Blacksmith
participant ECR as AWS ECR
participant GHCR as GitHub Container Registry
participant ECS as AWS ECS
Dev->>GH: Push to main/staging
GH->>BS: Trigger CI on blacksmith-4vcpu-ubuntu-2404
par Test Phase
BS->>BS: Run tests with Bun/Node
BS->>BS: Build application
BS->>GH: Upload coverage to Codecov
end
par Docker Build Phase (after tests pass)
BS->>BS: Build GHCR images (useblacksmith/build-push-action@v2)
BS->>BS: Build ECR images (useblacksmith/build-push-action@v2)
BS->>BS: Deploy Trigger.dev
end
par Push Phase (after ECR deployment)
BS->>GHCR: Push multi-arch Docker images
BS->>ECR: Push Docker images
BS->>ECS: Update ECS services with new images
end
par Final Phase
BS->>BS: Run database migrations
BS->>BS: Process documentation embeddings
end
Note over BS: All runners migrated from ubuntu-latest to blacksmith-4vcpu-ubuntu-2404
Note over BS: Docker actions migrated from standard to useblacksmith/* versions
Note over BS: GitHub Actions caching removed (now handled by Blacksmith)
11 files reviewed, 2 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
use blacksmith for ci
Type of Change
Testing
N/A
Checklist