-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(ui): standardized 404, chat, and invite pages #1472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ai/chat/[identifier]
…ses sim.ai/chat/[identifier]" This reverts commit c68c052.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Summary
This PR standardizes the UI styling across 404, chat error, and invite pages by implementing consistent layout patterns and removing complex theming logic.
Key Changes:
- Navigation component: Simplified auth button visibility logic to only check
isHostedflag instead of variant conditions - Error pages: Applied unified styling with
min-h-screen bg-white, centered content containers (max-w-[410px]), and consistent contact support footers - Invite layout: Removed
AuthBackgroundwrapper and dark theme detection logic, switching to a simpler white background approach - 404 page: Complete redesign matching the error state pattern with proper typography hierarchy and consistent spacing
The changes eliminate redundant dark theme logic and create a cohesive visual experience across these pages. All pages now share the same structural patterns: white background, centered content with consistent max-widths, and uniform contact support footers.
Confidence Score: 5/5
- This PR is safe to merge with minimal risk
- Score reflects straightforward UI standardization changes with no logical errors, security issues, or breaking changes. The changes simplify existing code by removing complex theming logic and applying consistent styling patterns.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| apps/sim/app/(landing)/components/nav/nav.tsx | 5/5 | Simple auth button logic change: removed variant condition, now shows auth buttons only when hosted |
| apps/sim/app/chat/components/error-state/error-state.tsx | 5/5 | Standardized layout with consistent styling, added min-height and contact support footer |
| apps/sim/app/invite/components/layout.tsx | 5/5 | Simplified layout by removing AuthBackground wrapper and dark theme logic, now uses basic white background |
| apps/sim/app/not-found.tsx | 5/5 | Complete redesign to match error state styling with consistent layout, typography, and contact support footer |
Sequence Diagram
sequenceDiagram
participant User
participant App
participant Nav
participant ErrorPage
participant NotFoundPage
participant InvitePage
Note over User, InvitePage: Standardized Page Layout Flow
User->>App: Navigate to error/404/invite page
App->>Nav: Render with variant='auth'
Nav->>Nav: Check isHosted flag
alt When hosted
Nav-->>User: Show auth buttons
else When not hosted
Nav-->>User: Hide auth buttons
end
App->>ErrorPage: Load chat error state
ErrorPage->>ErrorPage: Apply min-h-screen bg-white
ErrorPage->>ErrorPage: Center content with max-width
ErrorPage-->>User: Display standardized error layout
App->>NotFoundPage: Load 404 page
NotFoundPage->>NotFoundPage: Force light theme
NotFoundPage->>NotFoundPage: Apply consistent styling
NotFoundPage-->>User: Display standardized 404 layout
App->>InvitePage: Load invite layout
InvitePage->>InvitePage: Remove AuthBackground wrapper
InvitePage->>InvitePage: Apply white background
InvitePage-->>User: Display simplified invite layout
Note over User, InvitePage: All pages now share consistent styling patterns
4 files reviewed, no comments
Summary
standardized 404, chat, and invite pages
Type of Change
Testing
Manually
Checklist
Screenshots