Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

remove atomic updates for trigger, will add back in later

Type of Change

  • Bug fix

Testing

manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Sep 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Building Building Preview Comment Sep 28, 2025 5:37am
sim Building Building Preview Comment Sep 28, 2025 5:37am

@waleedlatif1 waleedlatif1 merged commit 67c993d into staging Sep 28, 2025
3 of 5 checks passed
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR removes atomic deployment functionality from the Trigger.dev CI workflow by eliminating the two-stage deploy-then-promote process. The changes remove the --skip-promotion flags from deployment commands and delete the entire promotion workflow, making deployments immediate instead of atomic.

  • Workflow Simplification: Removed the trigger-promote job from the main CI pipeline and deleted the standalone promotion workflow file
  • Deployment Changes: Modified trigger deployment commands to deploy immediately rather than requiring a separate promotion step
  • Dependency Updates: Updated the process-docs job to depend directly on migrations instead of trigger-promote

The changes effectively trade deployment safety (atomic updates) for simplicity, with the author noting they plan to add atomic updates back later.

Confidence Score: 4/5

  • This PR is safe to merge but removes important deployment safety features
  • Score reflects that while the changes are technically sound and won't break functionality, removing atomic deployment capability introduces deployment risk that should be monitored closely
  • No files require special attention - changes are straightforward workflow modifications

Important Files Changed

File Analysis

Filename        Score        Overview
.github/workflows/ci.yml 4/5 Removed trigger-promote job and updated docs processing dependency, simplified workflow chain
.github/workflows/trigger-deploy.yml 4/5 Removed --skip-promotion flags from deploy commands, enabling immediate deployment
.github/workflows/trigger-promote.yml 5/5 Deleted promotion workflow file entirely, removing atomic deployment capability

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant CI as CI Pipeline
    participant TB as Test & Build
    participant BI as Build Images
    participant TD as Trigger Deploy
    participant M as Migrations
    participant PD as Process Docs

    Dev->>CI: Push to main/staging
    CI->>TB: Run tests and build
    TB-->>CI: Success
    CI->>BI: Build container images
    BI-->>CI: Success
    
    Note over CI,TD: BEFORE: Deploy with --skip-promotion
    Note over CI,TD: AFTER: Deploy immediately (no promotion step)
    
    CI->>TD: Deploy to Trigger.dev
    Note over TD: Was: deploy --skip-promotion<br/>Now: deploy (immediate)
    TD-->>CI: Success
    
    Note over CI,M: Removed: trigger-promote job
    Note over CI,M: (Atomic deployment capability removed)
    
    CI->>M: Run database migrations
    M-->>CI: Success
    CI->>PD: Process docs embeddings
    PD-->>CI: Success
Loading

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants