Skip to content

fix(ci): capture correct deployment version output #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sg312 merged 4 commits into from
Sep 30, 2025
Merged

fix(ci): capture correct deployment version output #1512

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
312b890
Capture correct deployment version output
Sg312 Sep 30, 2025
40dddd7
Add trigger access token to each step
Sg312 Sep 30, 2025
96a298f
Merge branch 'staging' into fix/ci-trigger-5
Sg312 Sep 30, 2025
bc15e99
Use correct arn
Sg312 Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/trigger-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,34 +44,34 @@ jobs:
if: github.ref == 'refs/heads/staging'
id: deploy-staging
working-directory: ./apps/sim
env:
TRIGGER_ACCESS_TOKEN: ${{ secrets.TRIGGER_ACCESS_TOKEN }}
run: |
npx --yes trigger.dev@4.0.4 deploy -e staging --skip-promotion
Copy link
Contributor

@greptile-apps greptile-apps bot Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: This deploy command no longer captures output or sets any step outputs. The subsequent Parameter Store step will fail because deploymentVersion won't exist.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: .github/workflows/trigger-deploy.yml
Line: 48:48

Comment:
logic: This deploy command no longer captures output or sets any step outputs. The subsequent Parameter Store step will fail because `deploymentVersion` won't exist.

How can I resolve this? If you propose a fix, please make it concise.

echo "version=$TRIGGER_DEPLOYMENT_VERSION" >> $GITHUB_OUTPUT
echo "Deployed version: $TRIGGER_DEPLOYMENT_VERSION"

- name: Store Staging version in Parameter Store
if: github.ref == 'refs/heads/staging'
run: |
aws ssm put-parameter \
--name "${{ secrets.TRIGGER_VERSION_SECRET_MANAGER_STAGING }}" \
--value "${{ steps.deploy-staging.outputs.version }}" \
--value "${{ steps.deploy-staging.outputs.deploymentVersion }}" \
--type "String" \
--overwrite

- name: Deploy to Trigger.dev (Production)
if: github.ref == 'refs/heads/main'
id: deploy-production
working-directory: ./apps/sim
env:
TRIGGER_ACCESS_TOKEN: ${{ secrets.TRIGGER_ACCESS_TOKEN }}
run: |
npx --yes trigger.dev@4.0.4 deploy --skip-promotion
echo "version=$TRIGGER_DEPLOYMENT_VERSION" >> $GITHUB_OUTPUT
echo "Deployed version: $TRIGGER_DEPLOYMENT_VERSION"

- name: Store Production version in Parameter Store
if: github.ref == 'refs/heads/main'
run: |
aws ssm put-parameter \
--name "${{ secrets.TRIGGER_VERSION_SECRET_MANAGER_PROD }}" \
--value "${{ steps.deploy-production.outputs.version }}" \
--value "${{ steps.deploy-production.outputs.deploymentVersion }}" \
--type "String" \
--overwrite