Fix/remove trigger promotion

[Sg312]

Summary

moves trigger.dev deploy to the end

Fixes #(issue)

Type of Change

• Bug fix

Testing

n/a

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Ready	Preview	Comment	Oct 1, 2025 1:36am
sim	Ready	Preview	Comment	Oct 1, 2025 1:36am

[greptile-apps]

Greptile Overview

Summary

This PR optimizes the CI pipeline by restructuring the Trigger.dev deployment timing and simplifies the deployment process itself. The changes move the Trigger.dev deployment from an early blocking position in the pipeline (after test-build) to later in the pipeline (after build-amd64), allowing it to run in parallel with documentation processing. This architectural change reduces overall pipeline execution time by enabling image builds to start immediately after tests complete, rather than waiting for deployment to finish.

Additionally, the PR removes complex version management features from the Trigger.dev deployment workflow, including AWS Parameter Store integration, version extraction logic, and promotion control mechanisms. The deployment commands are simplified from using --skip-promotion flags and version tracking to straightforward deployment commands. This change eliminates the AWS credential requirements and associated permissions that were previously needed for Parameter Store operations.

The modifications integrate well with the existing CI workflow structure, maintaining the same deployment functionality while improving performance characteristics. The dependency chain is preserved to ensure ECR images are available when Trigger.dev deployment occurs, which appears to be a requirement for the deployment process.

PR Description Notes:

• The PR description is incomplete and uses the template format without filling in specific details about the changes
• No issue reference, testing information, or change type is specified
• The checklist items are not checked off

Important Files Changed

Changed Files

Filename	Score	Overview
.github/workflows/ci.yml	5/5	Optimizes CI pipeline by moving Trigger.dev deployment to run in parallel with docs processing instead of blocking image builds
.github/workflows/trigger-deploy.yml	4/5	Removes version tracking and AWS Parameter Store integration, simplifying deployment commands but removing version management capabilities

Confidence score: 4/5

• This PR is generally safe to merge with minimal immediate risk but removes functionality that may be needed
• Score reflects optimization benefits balanced against removal of version management features that could be important for deployment tracking or rollbacks
• Pay close attention to .github/workflows/trigger-deploy.yml to ensure version tracking removal doesn't impact operational requirements

Sequence Diagram

sequenceDiagram
    participant User
    participant GitHub as "GitHub (Push/PR)"
    participant TestBuild as "test-build"
    participant AMD64 as "build-amd64"
    participant ARM64 as "build-ghcr-arm64"
    participant Manifests as "create-ghcr-manifests"
    participant TriggerDeploy as "trigger-deploy"
    participant ProcessDocs as "process-docs"
    participant ECR as "Amazon ECR"
    participant GHCR as "GitHub Container Registry"
    participant TriggerDev as "Trigger.dev"

    User->>GitHub: "Push to main/staging or Create PR"
    
    GitHub->>TestBuild: "Trigger test-build job"
    TestBuild->>TestBuild: "Run tests and build"
    TestBuild->>GitHub: "Complete successfully"
    
    par Parallel execution after test-build
        GitHub->>AMD64: "Start build-amd64 (if push to main/staging)"
        AMD64->>ECR: "Push images with staging/latest tags"
        Note over AMD64,GHCR: "For main branch only"
        AMD64->>GHCR: "Push AMD64 images with architecture-specific tags"
        AMD64->>GitHub: "AMD64 build complete"
    and
        GitHub->>ARM64: "Start build-ghcr-arm64 (if push to main only)"
        ARM64->>GHCR: "Push ARM64 images with architecture-specific tags"
        ARM64->>GitHub: "ARM64 build complete"
    end
    
    GitHub->>Manifests: "Start create-ghcr-manifests (if main, needs both AMD64 and ARM64)"
    Manifests->>GHCR: "Create and push multi-arch manifests"
    Manifests->>GitHub: "Manifests created"
    
    par Parallel execution after AMD64 build
        GitHub->>TriggerDeploy: "Start trigger-deploy (needs build-amd64)"
        TriggerDeploy->>TriggerDev: "Deploy to staging/production"
        TriggerDev->>TriggerDeploy: "Deployment complete"
        TriggerDeploy->>GitHub: "Trigger deploy complete"
    and
        GitHub->>ProcessDocs: "Start process-docs (needs build-amd64)"
        ProcessDocs->>ProcessDocs: "Process documentation embeddings"
        ProcessDocs->>GitHub: "Docs processing complete"
    end

Loading

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}