Feat(microsoftteams-file): new trigger + file upload #1590

aadamgough · 2025-10-10T03:18:27Z

Summary

Added new teams trigger with file upload so users can access their files from teams chat.

Type of Change

New feature

Testing

Tested with uploading files and the new trigger system.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2025-10-10T03:18:32Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
sim	Ready	Preview	Comment	Oct 15, 2025 2:54am

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Oct 15, 2025 2:54am

greptile-apps

Greptile Overview

Summary

Added Microsoft Teams chat subscription trigger using Microsoft Graph API change notifications, enabling workflows to react to new chat messages with automatic file attachment downloads.

Major Changes:

Implemented new microsoftteams_chat_subscription trigger that subscribes to Teams chat messages via Graph API
Added automatic file download and S3 upload for message attachments from SharePoint/OneDrive URLs with multiple fallback strategies
Created background job to renew Teams subscriptions every 2 days before they expire (max lifetime ~3 days)
Added validation token handling for Graph API subscription verification
Integrated idempotency protection using x-teams-notification-id header to prevent duplicate message processing
Extended read_channel and read_chat tools with optional includeAttachments parameter for hosted contents

Implementation Details:

Subscription lifecycle: create → validate → receive notifications → auto-renew → expire
File attachments are fetched from various sources (SharePoint, OneDrive, direct URLs) and uploaded to S3 with presigned URLs
Changed Teams webhook response from JSON to 202 Accepted for proper async processing

Confidence Score: 3/5

PR has solid architecture but contains a critical bug that will break multi-workflow Teams setups
The subscription cleanup logic in teams-subscriptions.ts:46-48 deletes ALL chat subscriptions for a credential instead of just the one being replaced, which will break other workflows using Teams triggers. The file attachment download logic is complex with many silent error handlers that could hide issues. The renewal timing (check 24h, run every 2 days) has a potential race condition if jobs are delayed.
Pay close attention to apps/sim/lib/webhooks/teams-subscriptions.ts (subscription cleanup bug) and apps/sim/lib/webhooks/utils.ts (complex file download logic with silent errors)

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/lib/webhooks/utils.ts	3/5	Added complex Teams Graph notification formatting with file download/upload logic for attachments from SharePoint/OneDrive URLs. File download logic has extensive fallback mechanisms but silently continues on errors.
apps/sim/triggers/microsoftteams/chat_webhook.ts	5/5	New trigger configuration for Microsoft Teams chat subscriptions. Clean configuration with appropriate scopes and output definitions.
apps/sim/lib/webhooks/teams-subscriptions.ts	4/5	Creates Microsoft Teams Graph subscriptions and cleans up old subscriptions. Logic appears sound but deletes ALL chat subscriptions matching URL pattern, not just those for this webhook.
apps/sim/background/teams-subscription-renewal.ts	4/5	Background job for renewing Teams subscriptions before expiry. Includes fallback to recreate if subscription not found. Well-structured with proper error handling.
apps/sim/lib/webhooks/processor.ts	4/5	Added Teams notification idempotency support and improved inactive webhook logging. Changed response from JSON to 202 for Teams webhooks.

Sequence Diagram

sequenceDiagram
    participant User
    participant TeamsClient as Microsoft Teams
    participant GraphAPI as MS Graph API
    participant Webhook as /api/webhooks/trigger/[path]
    participant Processor as Webhook Processor
    participant Queue as Background Queue
    participant Executor as Webhook Execution
    participant S3 as S3 Storage
    participant Workflow as Workflow Engine

    Note over User,Workflow: Setup Phase
    User->>Webhook: POST /api/webhooks (create subscription)
    Webhook->>GraphAPI: POST /subscriptions (create chat subscription)
    GraphAPI-->>Webhook: Subscription ID + expiration
    Webhook->>Webhook: Store subscription ID in providerConfig
    Webhook-->>User: Success

    Note over User,Workflow: Message Received
    TeamsClient->>GraphAPI: User sends message in chat
    GraphAPI->>Webhook: POST notification (changeType: created)
    Webhook->>Webhook: Validate notification token
    Webhook->>Processor: findWebhookAndWorkflow(path)
    Processor->>Processor: Check idempotency (x-teams-notification-id)
    
    alt First time processing
        Processor->>GraphAPI: GET /chats/{chatId}/messages/{messageId}
        GraphAPI-->>Processor: Message details
        
        opt includeAttachments=true
            Processor->>GraphAPI: GET hostedContents
            GraphAPI-->>Processor: Base64 content
            
            loop For each attachment
                Processor->>GraphAPI: Fetch from SharePoint/OneDrive URL
                GraphAPI-->>Processor: File buffer
                Processor->>S3: Upload file
                S3-->>Processor: S3 key + presigned URL
            end
        end
        
        Processor->>Queue: Enqueue webhook execution
        Queue-->>Webhook: 202 Accepted
        
        Queue->>Executor: Execute webhook job
        Executor->>Workflow: Trigger workflow with message + attachments
        Workflow-->>Executor: Execution complete
    else Duplicate notification
        Processor-->>Webhook: 202 Accepted (idempotent)
    end

    Note over GraphAPI,Webhook: Subscription Renewal (every 2 days)
    GraphAPI->>GraphAPI: Check subscriptions expiring < 24h
    GraphAPI->>GraphAPI: PATCH /subscriptions/{id} (renew)
    GraphAPI->>GraphAPI: Update expiration in DB

_{22 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2025-10-10T03:23:24Z

apps/sim/lib/webhooks/teams-subscriptions.ts

+        const chatSubscriptions = allSubscriptions.filter((sub: any) =>
+          sub.resource?.includes('/chats/')
+        )


logic: deletes ALL chat subscriptions for this credential that match the URL pattern, not just subscriptions for this specific webhook. if the user has multiple workflows with Teams chat triggers, this will break other workflows' subscriptions.

Suggested change

const chatSubscriptions = allSubscriptions.filter((sub: any) =>

sub.resource?.includes('/chats/')

)

const chatSubscriptions = allSubscriptions.filter((sub: any) =>

sub.resource?.includes('/chats/') && sub.clientState === webhookData.id

)

Prompt To Fix With AI

This is a comment left during a code review. Path: apps/sim/lib/webhooks/teams-subscriptions.ts Line: 46:48 Comment: **logic:** deletes ALL chat subscriptions for this credential that match the URL pattern, not just subscriptions for this specific webhook. if the user has multiple workflows with Teams chat triggers, this will break other workflows' subscriptions. ```suggestion const chatSubscriptions = allSubscriptions.filter((sub: any) => sub.resource?.includes('/chats/') && sub.clientState === webhookData.id ) ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2025-10-10T03:23:25Z

apps/sim/lib/webhooks/utils.ts

+                      const encodedUrl = Buffer.from(contentUrl)
+                        .toString('base64')
+                        .replace(/\+/g, '-')
+                        .replace(/\//g, '_')
+                        .replace(/=+$/, '')


style: base64 encoding should use 'utf-8' encoding explicitly, or better yet use encodeURIComponent for URL encoding instead of base64

Prompt To Fix With AI

This is a comment left during a code review. Path: apps/sim/lib/webhooks/utils.ts Line: 296:300 Comment: **style:** base64 encoding should use 'utf-8' encoding explicitly, or better yet use `encodeURIComponent` for URL encoding instead of base64 How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2025-10-10T03:23:25Z

apps/sim/lib/webhooks/utils.ts

+                  url,
+                  sourceUrl: contentUrl,
+                })
+              } catch {}


style: empty catch blocks swallow all errors including critical ones like S3 upload failures. at minimum, log the error

Prompt To Fix With AI

This is a comment left during a code review. Path: apps/sim/lib/webhooks/utils.ts Line: 466:466 Comment: **style:** empty catch blocks swallow all errors including critical ones like S3 upload failures. at minimum, log the error How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2025-10-10T03:23:26Z

apps/sim/background/teams-subscription-renewal.ts

+
+    try {
+      // Find all Microsoft Teams webhooks with chat subscriptions that expire soon
+      // Check for subscriptions expiring within the next 24 hours


style: checking for subscriptions expiring within 24 hours but job runs every 2 days according to comment on line 16. if the job is delayed, subscriptions may expire before renewal

Prompt To Fix With AI

This is a comment left during a code review. Path: apps/sim/background/teams-subscription-renewal.ts Line: 23:23 Comment: **style:** checking for subscriptions expiring within 24 hours but job runs every 2 days according to comment on line 16. if the job is delayed, subscriptions may expire before renewal How can I resolve this? If you propose a fix, please make it concise.

icecrasher321 · 2025-10-13T22:43:53Z

apps/sim/app/api/webhooks/[id]/route.ts

      }
    }

+    // If it's a Microsoft Teams webhook with a subscription, delete the Graph subscription


why are we doing this....

we want to remove any external Graph subscription as well, and since we run the renewal subscription we need to delete it on the graph end too.

icecrasher321 · 2025-10-13T22:44:57Z

apps/sim/app/api/webhooks/route.ts

    // If path is missing
    if (!finalPath || finalPath.trim() === '') {
-      if (isCredentialBased) {
+      if (isCredentialBased || isMicrosoftTeamsChatSubscription) {


why are we treating a subscription to a chat as credential based?

bc we need the credential to create the graph subscription, we create the callback when we create this subscription

icecrasher321 · 2025-10-13T22:45:31Z

...w-block/components/sub-block/components/trigger-config/components/trigger-config-section.tsx

  const [copied, setCopied] = useState<string | null>(null)
  const accessiblePrefixes = useAccessibleReferencePrefixes(blockId)

+  // Sync credential field values from subblock store to config


Is this intended -- this runs on all triggers right?

it returns early when there are no credential fields set, supposed to target the credential-based triggers like teams chat

fix bc if we open the modal, we screw up the other guys stuf.

icecrasher321 · 2025-10-13T22:46:39Z

apps/sim/background/teams-subscription-renewal.ts

+ * Background job to renew Microsoft Teams Graph API subscriptions before they expire.
+ * Runs periodically to check for subscriptions expiring soon and renews them.
+ */
+export const renewTeamsSubscriptions = task({


you made a new trigger.dev task to renew chat subscriptions?

aadamgough · 2025-10-14T01:50:02Z

apps/sim/app/api/cron/renew-subscriptions/route.ts

use verifyCronAuth (verifyCronSecret)

aadamgough · 2025-10-14T01:58:24Z

.../components/workflow-block/components/sub-block/components/trigger-config/trigger-config.tsx

confirm:

availableTriggers={availableTriggers} selectedTriggerId={selectedTriggerId} onTriggerChange={(newTriggerId) => { setStoredTriggerId(newTriggerId) // Clear config when changing trigger type setTriggerConfig({}) }}

* adding file logic and chat trigger * working trig * teams specific logic * greptile comments * lint * cleaned up * save modal changes * created a interface for subscriptions * removed trigger task * reduce comments * removed trig task * removed comment * simplified * added tele logic back * addressed some more comments * simplified db call * cleaned up utils * helper telegram * removed fallback * removed scope * simplify to use helpers * fix credential resolution * add logs * fix * fix attachment case --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Adam Gough <adamgough@Adams-MacBook-Pro.local> Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>

greptile-apps bot reviewed Oct 10, 2025

View reviewed changes

waleedlatif1 force-pushed the staging branch from 3eb2987 to 923595f Compare October 11, 2025 00:20

vercel bot temporarily deployed to Preview October 12, 2025 02:16 Inactive

aadamgough force-pushed the feat/microsoftteams-file branch from 3c012ed to 507790b Compare October 12, 2025 02:28

vercel bot temporarily deployed to Preview October 12, 2025 02:28 Inactive

vercel bot temporarily deployed to Preview October 12, 2025 02:29 Inactive

waleedlatif1 force-pushed the staging branch from 3d34132 to b10b246 Compare October 12, 2025 03:37

Adam Gough and others added 5 commits October 12, 2025 09:30

adding file logic and chat trigger

68b5b4e

working trig

07fcf04

teams specific logic

7be20de

greptile comments

3aca1c9

lint

66b4143

aadamgough force-pushed the feat/microsoftteams-file branch from 6e3b8d8 to 66b4143 Compare October 12, 2025 16:30

vercel bot temporarily deployed to Preview October 12, 2025 16:30 Inactive

cleaned up

a0018ce

vercel bot temporarily deployed to Preview October 13, 2025 20:14 Inactive

save modal changes

e72c9b1

vercel bot temporarily deployed to Preview October 13, 2025 20:49 Inactive

icecrasher321 reviewed Oct 13, 2025

View reviewed changes

created a interface for subscriptions

02c4c3c

vercel bot temporarily deployed to Preview October 13, 2025 23:44 Inactive

removed trigger task

4f91208

vercel bot temporarily deployed to Preview October 14, 2025 00:01 Inactive

reduce comments

db874e9

vercel bot temporarily deployed to Preview October 14, 2025 00:08 Inactive

removed trig task

08c641f

vercel bot temporarily deployed to Preview October 14, 2025 00:56 Inactive

aadamgough commented Oct 14, 2025

View reviewed changes

apps/sim/app/api/cron/renew-subscriptions/route.ts

Copy link

Contributor Author

aadamgough Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use verifyCronAuth (verifyCronSecret)

aadamgough commented Oct 14, 2025

View reviewed changes

addressed some more comments

9fa0fb7

vercel bot temporarily deployed to Preview October 14, 2025 02:56 Inactive

simplified db call

74f7b2f

vercel bot temporarily deployed to Preview October 14, 2025 03:05 Inactive

cleaned up utils

610d85e

vercel bot temporarily deployed to Preview October 14, 2025 03:24 Inactive

helper telegram

d49b120

vercel bot temporarily deployed to Preview October 14, 2025 21:51 Inactive

removed fallback

45d529f

vercel bot temporarily deployed to Preview October 14, 2025 22:06 Inactive

removed scope

0af2747

vercel bot temporarily deployed to Preview October 14, 2025 22:15 Inactive

icecrasher321 added 2 commits October 14, 2025 19:17

Merge staging to get attachment processing helpers

17807bf

simplify to use helpers

ae40a6a

vercel bot deployed to Preview October 15, 2025 02:26 View deployment

fix credential resolution

d7d9f64

vercel bot temporarily deployed to Preview October 15, 2025 02:33 Inactive

add logs

6b619cb

vercel bot temporarily deployed to Preview October 15, 2025 02:42 Inactive

fix

703af2a

vercel bot temporarily deployed to Preview October 15, 2025 02:48 Inactive

fix attachment case

9b3b4fd

vercel bot temporarily deployed to Preview October 15, 2025 02:54 Inactive

icecrasher321 merged commit 6c9fce5 into staging Oct 15, 2025
9 checks passed

waleedlatif1 mentioned this pull request Oct 15, 2025

v0.4.15: helm chart updates, telegram tools, youtube tools, file upload support for more blocks #1636

Merged

waleedlatif1 deleted the feat/microsoftteams-file branch November 6, 2025 01:25

Feat(microsoftteams-file): new trigger + file upload #1590

Feat(microsoftteams-file): new trigger + file upload #1590

Uh oh!

Conversation

aadamgough commented Oct 10, 2025

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Greptile Overview

Summary

Confidence Score: 3/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Oct 10, 2025 •

edited

Loading