Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

pin all workflows and Dockerfiles to Bun v1.2.22 because bun released v1.3 and requires a larger rework

Type of Change

  • Bug fix

Testing

Tested manually.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Oct 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Building Building Preview Comment Oct 11, 2025 0:35am
sim Building Building Preview Comment Oct 11, 2025 0:35am

@waleedlatif1 waleedlatif1 marked this pull request as ready for review October 11, 2025 00:35
@waleedlatif1 waleedlatif1 merged commit 5a943bc into staging Oct 11, 2025
3 of 5 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/gh-actions branch October 11, 2025 00:36
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

Pins Bun version from latest to 1.2.22 across 6 GitHub Actions workflow files to avoid breaking changes from Bun v1.3 release.

  • All workflow files correctly updated with pinned version
  • .devcontainer/Dockerfile still uses FROM oven/bun:canary (unpinned) - should be updated to 1.2.22 per PR title

Confidence Score: 3/5

  • Safe to merge but incomplete - missing Dockerfile update
  • All workflow changes are correct and will prevent CI breakage from Bun v1.3, but the PR title promises to pin "all workflows and Dockerfiles" while .devcontainer/Dockerfile remains unpinned at :canary
  • .devcontainer/Dockerfile needs to be updated from oven/bun:canary to oven/bun:1.2.22

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/docs-embeddings.yml 5/5 Correctly pins Bun from latest to 1.2.22
.github/workflows/i18n.yml 5/5 Correctly pins Bun from latest to 1.2.22 in both jobs
.github/workflows/migrations.yml 5/5 Correctly pins Bun from latest to 1.2.22
.github/workflows/publish-cli.yml 5/5 Correctly pins Bun from latest to 1.2.22
.github/workflows/publish-ts-sdk.yml 5/5 Correctly pins Bun from latest to 1.2.22
.github/workflows/trigger-deploy.yml 5/5 Correctly pins Bun from latest to 1.2.22

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant GHA as GitHub Actions
    participant Bun as Bun Registry
    
    Note over Dev,Bun: Before (using latest)
    Dev->>GHA: Trigger workflow
    GHA->>Bun: Request latest Bun
    Bun-->>GHA: Returns v1.3 (breaking)
    GHA->>GHA: Build fails
    
    Note over Dev,Bun: After (using 1.2.22)
    Dev->>GHA: Trigger workflow
    GHA->>Bun: Request Bun 1.2.22
    Bun-->>GHA: Returns v1.2.22 (stable)
    GHA->>GHA: Build succeeds
Loading

Additional Comments (1)

  1. .devcontainer/Dockerfile, line 2 (link)

    logic: The PR title says "pin all workflows and Dockerfiles to Bun v1.2.22" but this Dockerfile still uses :canary which is unpinned

6 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants