Skip to content

fix(tool-calls): remove redundant input/output fields in favor of arguments/response, exclude isExpanded for tools in agents in workflow change detection #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Oct 15, 2025
Merged

fix(tool-calls): remove redundant input/output fields in favor of arguments/response, exclude isExpanded for tools in agents in workflow change detection #1630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/sim/executor/handlers/agent/agent-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,8 +928,7 @@ export class AgentBlockHandler implements BlockHandler {
endTime: tc.endTime,
duration: tc.duration,
arguments: tc.arguments || tc.input || {},
input: tc.arguments || tc.input || {}, // Keep both for backward compatibility
output: tc.result || tc.output,
result: tc.result || tc.output,
}
}

Expand Down
27 changes: 25 additions & 2 deletions apps/sim/lib/workflows/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,23 @@ export async function updateWorkflowRunCounts(workflowId: string, runs = 1) {
}
}

/**
* Sanitize tools array by removing UI-only fields
* @param tools - The tools array to sanitize
* @returns A sanitized tools array
*/
function sanitizeToolsForComparison(tools: any[] | undefined): any[] {
if (!Array.isArray(tools)) {
return []
}

return tools.map((tool) => {
// Remove UI-only field: isExpanded
const { isExpanded, ...cleanTool } = tool
return cleanTool
})
}

/**
* Normalize a value for consistent comparison by sorting object keys
* @param value - The value to normalize
Expand Down Expand Up @@ -385,8 +402,14 @@ export function hasWorkflowChanged(
}

// Get values with special handling for null/undefined
const currentValue = currentSubBlocks[subBlockId].value ?? null
const deployedValue = deployedSubBlocks[subBlockId].value ?? null
let currentValue = currentSubBlocks[subBlockId].value ?? null
let deployedValue = deployedSubBlocks[subBlockId].value ?? null

// Special handling for 'tools' subBlock - sanitize UI-only fields
if (subBlockId === 'tools' && Array.isArray(currentValue) && Array.isArray(deployedValue)) {
currentValue = sanitizeToolsForComparison(currentValue)
deployedValue = sanitizeToolsForComparison(deployedValue)
}

// For string values, compare directly to catch even small text changes
if (typeof currentValue === 'string' && typeof deployedValue === 'string') {
Expand Down