fix(trace-spans): fixed small styling bugs#1900
Merged
aadamgough merged 2 commits intostagingfrom Nov 11, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR fixes styling bugs in the trace span timeline visualization. The changes refactor hover interaction handling and correct visual issues with the timeline elements. Key improvements:
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant TraceSpans
participant TraceSpanItem
participant DOM
User->>TraceSpanItem: Hover over timeline
TraceSpanItem->>TraceSpanItem: onPointerMove event
TraceSpanItem->>TraceSpanItem: Calculate clamped percent
TraceSpanItem->>TraceSpanItem: setLocalHoveredPercent
TraceSpanItem->>TraceSpans: onTimelineHover(clientX, clientY, rect)
TraceSpans->>TraceSpans: Calculate workflow time & position
TraceSpans->>TraceSpans: setHoveredWorkflowMs, setHoveredX, setHoveredY
TraceSpans->>DOM: Render tooltip at calculated position
TraceSpanItem->>DOM: Render hover line at localHoveredPercent
User->>TraceSpanItem: Move pointer away
TraceSpanItem->>TraceSpanItem: onPointerLeave event
TraceSpanItem->>TraceSpanItem: setLocalHoveredPercent(null)
TraceSpanItem->>TraceSpans: onTimelineLeave()
TraceSpans->>TraceSpans: Clear hover states (null)
TraceSpans->>DOM: Remove tooltip
TraceSpanItem->>DOM: Remove hover line
|
waleedlatif1
pushed a commit
that referenced
this pull request
Nov 12, 2025
* fix trace spands timeline styling and hover tooltip * fixed invalid dom properties
waleedlatif1
pushed a commit
that referenced
this pull request
Nov 12, 2025
* fix trace spands timeline styling and hover tooltip * fixed invalid dom properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trace span styling has small bug for highlighting logs and the millisecond tag as well. In the video attached, the styling is fixed.
Type of Change
Testing
See video
Checklist
Screenshots/Videos
Screen.Recording.2025-11-11.at.1.24.22.PM.mov