fix(templates): fix template details page#1940
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR refactors the template details page from server-side rendering (SSR) to client-side rendering (CSR). The main changes include:
Critical Issue Found: Confidence Score: 1/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Browser
participant Page as page.tsx (Server)
participant Template as template.tsx (Client)
participant API as /api/templates/[id]
participant AuthAPI as /api/auth/get-session
User->>Browser: Navigate to template detail page
Browser->>Page: Request page
Page->>Template: Render TemplateDetails component
Template->>Browser: Show loading state
par Fetch template and session in parallel
Template->>API: GET /api/templates/{id}
API-->>Template: Return template data
and
Template->>AuthAPI: GET /api/auth/get-session
AuthAPI--xTemplate: 404 - Endpoint does not exist ❌
end
Template->>Browser: Display template (without user session)
alt User clicks "Use Template"
Template->>Template: Check if currentUserId exists
Note over Template: currentUserId will be null due to failed auth fetch
Template->>Browser: Redirect to login
end
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| const fetchCurrentUser = async () => { | ||
| try { | ||
| const response = await fetch('/api/auth/get-session') |
Contributor
There was a problem hiding this comment.
logic: /api/auth/get-session endpoint does not exist in the codebase. Use getSession() from @/lib/auth instead (server-side only), or access session data from a different client-side pattern.
For client-side components, session should either be:
- Passed as a prop from a server component
- Accessed via a proper session provider/context
- Or the component should remain server-side
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/templates/[id]/template.tsx
Line: 164:164
Comment:
**logic:** `/api/auth/get-session` endpoint does not exist in the codebase. Use `getSession()` from `@/lib/auth` instead (server-side only), or access session data from a different client-side pattern.
For client-side components, session should either be:
1. Passed as a prop from a server component
2. Accessed via a proper session provider/context
3. Or the component should remain server-side
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix template details page
Type of Change
Testing
Manual
Checklist